286494 - Fix libart for SVG use on OS/2 (short name for OS/2 DLL)

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Peter Weilbacher]

The libart library under other-licenses/libart_lgpl/ compiles fine under OS/2
but cannot be used due to the 8.3 char limitation for OS/2 DLLs. To be able to
use SVG we need a small patch to let Mozilla start when compiled with
--enable-svg and --enable-svg-renderer=libart.

Comment 1

[Peter Weilbacher]

Attachment: Use moz_art.dll as short name

With these two small changes libart can be used and SVG really works on OS/2!

Comment 2

[Mike Kaply [:mkaply]]

SHORT_LIBNAME is used by windows as well, so we need this in an if statement.

http://lxr.mozilla.org/seamonkey/source/extensions/access-builtin/accessproxy/Makefile.in#48

Nice find!

Comment 3

[Peter Weilbacher]

Right, thanks for the hint. Unfortunately, I can only get SVG working with a
debug build, and even there blue and red colors are reversed, so that e.g.
<http://www.croczilla.com/svg/samples/butterfly/butterfly.svg> appears in blue
instead of orange. An optimized build crashes on startup when compiled with
--enable-svg.
I will try to investigate a bit more before uploading a corrected patch.

Comment 4

[Peter Weilbacher]

Attachment: Short DLL name and BGRA pixel format for OS/2

Fixed to not use SHORT_LIBNAME on WinNT. Also use BGRA pixel format on OS/2
instead of RGBA. Now all samples on <http://www.croczilla.com/svg/samples/>
seem to get the correct colors, just the ones with a background image don't
work.

I guess work on this is really wasted as libart is deprecated, so we should
really get cairo working as SVG renderer on OS/2, but libart is easier...

This is also just work in progress, no text is yet displayed in the SVG
graphics, probably some font handling problem on OS/2.

Comment 5

[Mike Kaply [:mkaply]]

Text will never work with libart - cairo is required for that.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 177951 [details] [diff] [review]
Short DLL name and BGRA pixel format for OS/2

r/sr = mkaply

Comment 7

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 8

[Andy Willis (abwillis)]

Build is failing looking for moz_art_lgpl_s.a .  
I think the problem is that in the checked in version it did not take into
account the configure.in changes.

Comment 9

[Andy Willis (abwillis)]

Build is failing looking for moz_art_lgpl_s.a .  
The problem is that in the checked in version it did not take into account the
configure.in changes.
autoconf.mk has MOZ_LIBART_LIBS=-lmoz_art_lgpl -lm instead of MOZ_LIBART_LIBS =
-lmoz_art -lm.
The moz_art files were created successfully but the final link in bootstrap
fails because it is looking for the long name.

Comment 10

[Peter Weilbacher]

Attachment: configure changes for libart on OS/2

Indeed, sorry! My second patch was missing the configure.in additions. Here
they are again.

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 179327 [details] [diff] [review]
configure changes for libart on OS/2

r=mkaply. I'll get this in today.

Comment 12

[Mike Kaply [:mkaply]]

done.