286811 - Invalid URLs get logged into global history when XUL error pages are enabled

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[[e-mail]]

Steps to reproduce problem:
1. Turn on XUL error pages
2. Browse to an invalid URL e.g. https://www.domain.invalid/
3. Open history

Actual result: invalid URL is logged in global history

Expected results: global history is unchanged

Additional information: If your startup/new window/new tab preference specifies
the last loaded URL then that also includes those invalid URLs.

Comment 1

[OstGote!]

related to bug 9203

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

sorry about the part from bug 300863 in this patch (the OnNewURI part in hunk
1), but there was really no way to avoid it...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 190283 [details] [diff] [review]
patch

r=bzbarsky

Comment 4

[Darin Fisher]

Comment on attachment 190283 [details] [diff] [review]
patch

looks good, sr=darin

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 190283 [details] [diff] [review]
patch

low risk patch to not store error pages in history

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: merged to trunk

merged to trunk after Bug 300863

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.707; previous revision: 1.706
done
Checking in docshell/base/nsDocShell.h;
/cvsroot/mozilla/docshell/base/nsDocShell.h,v  <--  nsDocShell.h
new revision: 1.183; previous revision: 1.182
done