287158 - use requests in xpinstall so that defining JS_PARANOID_REQUEST does not result in CHECK_REQUEST killing the app because of xpinstall tasks

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, enhancement)

Description

[timeless]

summary statement: xpinstall (which is runs on background threads) violates the
js request api

the best links about this that i could find were:
http://www.mozilla.org/js/spidermonkey/apidoc/gen/api-JS_BeginRequest.html
http://archive.gingerall.cz/archives/public/sablot2004/msg00117.html

i can't really find much else about it (i have spoken with brendan and shaver
about it, although not in a long time)

fwiw, my process is not the cleanest, basically i built and ran w/ paranoid
request and patched until mozilla stopped being killed by spidermonkey.

js_paranoid_request is enforced by check_request
so any call to any jsapi.c function that does check_request needs to be in a request
[with a special gecko expcetion made for the main thread for performance reasons]

this is bug #1 of probably 5 or 6.

Comment 1

[timeless]

Attachment: wrap xpinstall jsapi calls in begin/end-request

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 178199 [details] [diff] [review]
wrap xpinstall jsapi calls in begin/end-request

r=dveditz

Comment 3

[timeless]

Comment on attachment 178199 [details] [diff] [review]
wrap xpinstall jsapi calls in begin/end-request

mozilla/xpinstall/src/nsJSInstall.cpp	1.115
mozilla/xpinstall/src/nsSoftwareUpdateRun.cpp	1.95
mozilla/xpinstall/src/nsXPITriggerInfo.cpp	1.28