Closed Bug 287621 Opened 19 years ago Closed 19 years ago

Right click (context menu) in source view margin should not change breakpoint

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: WeirdAl, Assigned: WeirdAl)

References

()

Details

Attachments

(1 file)

When I'm trying to adjust the properties of a breakpoint, a right-click will
cause onMarginClick to act, changing a current breakpoint to a future
breakpoint, and/or clearing a future breakpoint.

Steps to reproduce:
(1) Open a script to view in the Source Code panel.
(2) Set a current breakpoint through the Source Code panel.
(3) Right-click on the breakpoint through the Source Code panel.

Expected results:
A context menu for the current breakpoint.

Actual results:
A context menu for a future breakpoint.

All we have to do is add a check for (event.button == 0).  In that case, it is a
left-button mouse click.
Attached patch patchSplinter Review
Assignee: rginda → ajvincent
Status: NEW → ASSIGNED
Attachment #178527 - Flags: review?(rginda)
Comment on attachment 178527 [details] [diff] [review]
patch

r=rginda
Attachment #178527 - Flags: review?(rginda) → review+
Attachment #178527 - Flags: superreview?(bzbarsky)
Attachment #178527 - Flags: superreview?(bzbarsky) → superreview+
I'll need someone to check this in, please.
checked in by timeless :)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: