287672 - Rename message remote content blocking preference

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[[e-mail]]

Bug 274866 changed the effect of the message image blocking preference. We
should update the pref panel so that it reflects whatever the new reality is.

Comment 1

[[e-mail]]

Oh, and we'd better update Help too, while we're at it!

Comment 2

[Peter Lairo]

Are you referring to: 
Tools | options | Privacy | [x] Block loading of remote images in mail messages?

If so, how about: [x] Block loading of remote *content* in mail messages

BTW: It might be helpful to list somewhere (also here?) *which* content is
actually blocked. All? javascript? images-only?

Comment 3

[Peter Lairo]

Is this (simple?) bug really "Suite"-only? Do we need another bug for
Thunderbird (i could file it), or could such a change be made in Suite & TB
together?

Comment 4

[Worcester12345]

(In reply to comment #3)
> Is this (simple?) bug really "Suite"-only? Do we need another bug for
> Thunderbird (i could file it), or could such a change be made in Suite & TB
> together?

Didn't there used to be a "mailnews" component to bugzilla, or was that just
wrapped into "core"?

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

this bug is suite only. thunderbird also blocks all content, but i don't know
what the UI looks like. Whatever it is, it doesn't belong in this bug.

Comment 6

[Ian Neal]

If we do change the pref pane to read:
"Do not load remote content in Mail & Newsgroup messages"
then I see a couple of issues here:
1. Pref pane/tree name no longer completely matches all the prefs in it -
perhaps change to Images & Content?
2. Group box name no longer completely matches all the prefs in it - perhaps
change to Image & Content Acceptance Policy or create a separate groupbox for it?

Any thoughts?

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

And do users know what 'content' is? content of a mail is the text, and you do
want to see that.

Comment 8

[Ian Neal]

From mvl on irc:
[ ] allow messages to access remote servers

Still have to think of how/where to put the pref and renames of pref panes possibly

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Thinking about it some more, i'm not sure if that wording works.
It does show the intention of the pref: protect privacy by not contacting
servers.  But it gives no hint to users that wonder why images are not shown,
and are looking for a pref to fix it.

Comment 10

[Mike Cowperthwaite]

This is TB bug 266503.

Comment 11

[Ian Neal]

[] Block loading of remote content (for example images) in Mail & Newsgroup messages
or
[] Do not load remote content (for example images) in Mail & Newsgroup messages

or from TB equivalent patch

[] Block loading of remote images and other [remote] content in Mail & Newsgroup
messages

Comment 12

[[e-mail]]

[ ] Do not load images or other website content from Mail & Newsgroups messages

[ ] Allow messages to load and display remote images and other website content

Comment 13

[Ian Neal]

(In reply to comment #12)
> [ ] Do not load images or other website content from Mail & Newsgroups messages
> 
> [ ] Allow messages to load and display remote images and other website content

Unfortunately both those give one word on a second line.

How about:

[ ] Allow Mail & Newsgroup messages to load and display remote images
    and other website content

Would changing the header from "Images" to "Images & Content" be an idea and the
caption box to "Content Acceptance Policy"?

Comment 14

[Ian Neal]

Attachment: Patch v0.1

This patch:
* Changes title from "Images" to "Images & Content"
* Changes caption from "Image Acceptance Policy" to "Image & Content Acceptance
Policy"
* Changes label for content/image blocking in mailnews
* Removes accesskey conflict by changing one of the accesskeys for image
looping

Comment 15

[Michiel van Leeuwen (email: mvl+moz@)]

Wouldn't it better to move the pref to Mail & Newsgroups -> Massage Display?
That is where i would expect it.

Comment 16

[[e-mail]]

Don't we currently disable the mail pref if all images are disabled?
How does that affect content blocking anyway - do frames stop working?

Comment 17

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 179378 [details] [diff] [review]
Patch v0.1

>+<!ENTITY disableImageInMailNews.label       "Allow Mail &amp; Newsgroup messages to load and display remote images and other website content">

For a user, what has websites are viewed in a browser. What does website
content have to with mail message display? I think you can just leave that word
out.

Comment 18

[Michiel van Leeuwen (email: mvl+moz@)]

asking to make this bug lbok 1.7.x is useless, since everything it depends on
isn't on the 1.7 branch (and I very much disagree with tryin to add it there)

Comment 19

[Ian Neal]

Fixed by landing of bug 196272