288023 - fix PreFast warnings in layout/mathml

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Bernd]

e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (191):
warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in
call to 'isspace'.
	FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158)
	PATH: 

e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (232):
warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in
call to 'isspace'.
	FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158)
	PATH: 

e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (241):
warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in
call to 'isspace'.
	FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158)
	PATH: 
:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (463): warning
246: Local declaration of 'hashkey' hides declaration of the same name in an
outer scope:  see previous declaration at line 453 of
e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp.
	FUNCTION: nsMathMLOperators::LookupOperator (432)
	PATH: 453 

e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (471):
warning 246: Local declaration of 'hashkey' hides declaration of the same name
in an outer scope:  see previous declaration at line 453 of
e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp.
	FUNCTION: nsMathMLOperators::LookupOperator (432)
	PATH: 453 

e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (479):
warning 246: Local declaration of 'hashkey' hides declaration of the same name
in an outer scope:  see previous declaration at line 453 of
e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp.
	FUNCTION: nsMathMLOperators::LookupOperator (432)
	PATH: 453

Comment 1

[Bernd]

Attachment: patch

Comment 2

[rbs]

Comment on attachment 178798 [details] [diff] [review]
patch

-    nsStringKey hashkey(key);
-    gOperatorFound[form] = found =
(OperatorData*)gOperatorTable->Get(&hashkey);
+    nsStringKey hashKey(key);
+    gOperatorFound[form] = found =
(OperatorData*)gOperatorTable->Get(&hashKey);


Wow, I had to read several times to figure out what changed here...

Care to use |hkey| instead.

r=rbs

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 178798 [details] [diff] [review]
patch

what rbs said! choose a name that differs by more than just case

Comment 4

[Bernd]

fix checked in