Closed
Bug 288023
Opened 19 years ago
Closed 19 years ago
fix PreFast warnings in layout/mathml
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
References
Details
Attachments
(1 file)
3.23 KB,
patch
|
rbs
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (191): warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in call to 'isspace'. FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158) PATH: e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (232): warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in call to 'isspace'. FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158) PATH: e:\moz_src\mozilla\layout\mathml\base\src\nsmathmlmpaddedframe.cpp (241): warning 328: 'int' passed as parameter 1 when 'unsigned char' is required in call to 'isspace'. FUNCTION: nsMathMLmpaddedFrame::ParseAttribute (158) PATH: :\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (463): warning 246: Local declaration of 'hashkey' hides declaration of the same name in an outer scope: see previous declaration at line 453 of e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp. FUNCTION: nsMathMLOperators::LookupOperator (432) PATH: 453 e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (471): warning 246: Local declaration of 'hashkey' hides declaration of the same name in an outer scope: see previous declaration at line 453 of e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp. FUNCTION: nsMathMLOperators::LookupOperator (432) PATH: 453 e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp (479): warning 246: Local declaration of 'hashkey' hides declaration of the same name in an outer scope: see previous declaration at line 453 of e:\moz_src\mozilla\layout\mathml\content\src\nsmathmloperators.cpp. FUNCTION: nsMathMLOperators::LookupOperator (432) PATH: 453
Attachment #178798 -
Flags: review?(rbs)
Comment on attachment 178798 [details] [diff] [review] patch - nsStringKey hashkey(key); - gOperatorFound[form] = found = (OperatorData*)gOperatorTable->Get(&hashkey); + nsStringKey hashKey(key); + gOperatorFound[form] = found = (OperatorData*)gOperatorTable->Get(&hashKey); Wow, I had to read several times to figure out what changed here... Care to use |hkey| instead. r=rbs
Attachment #178798 -
Flags: review?(rbs) → review+
Attachment #178798 -
Flags: superreview?(roc)
Comment on attachment 178798 [details] [diff] [review] patch what rbs said! choose a name that differs by more than just case
Attachment #178798 -
Flags: superreview?(roc) → superreview+
fix checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•