Closed
Bug 288042
Opened 19 years ago
Closed 19 years ago
cairo/svg does not build on qt, xlib
Categories
(Core :: SVG, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
(Keywords: fixed1.8)
Attachments
(3 files, 2 obsolete files)
891 bytes,
patch
|
Details | Diff | Splinter Review | |
4.65 KB,
patch
|
tor
:
review+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
906 bytes,
patch
|
zack
:
review+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
nsSVGCairoCanvas.cpp currently only compiles on macosx and gtk, not qt or xlib.
Assignee | ||
Comment 1•19 years ago
|
||
this patch allows to get a Display* from an xlib drawing surface.
Attachment #178841 -
Flags: review?(roland.mainz)
Assignee | ||
Comment 2•19 years ago
|
||
makes GetPaintDevice (and GetPainter, for consistency) virtual, so that it can be called from other modules I could have used NS_EXPORT_ instead, but it looks like I'd still have to link to libgfx_qt.so. I think I prefer making the functions virtual, but if reviewers prefer I can change this.
Attachment #178863 -
Flags: review?(zack)
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #178864 -
Flags: review?(tor)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Updated•19 years ago
|
Attachment #178841 -
Attachment description: gfx/ part → gfx/src/{xlib,xprint} part
Attachment #178864 -
Flags: review?(tor) → review+
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 178841 [details] [diff] [review] gfx/src/{xlib,xprint} part this patch isn't actually needed...
Attachment #178841 -
Attachment is obsolete: true
Attachment #178841 -
Flags: review?(roland.mainz)
Assignee | ||
Comment 5•19 years ago
|
||
also eliminates the need for gfx/src/xlib changes.
Attachment #178864 -
Attachment is obsolete: true
Attachment #192196 -
Flags: review?(tor)
Assignee | ||
Updated•19 years ago
|
Target Milestone: mozilla1.8beta2 → mozilla1.8beta4
Attachment #192196 -
Flags: review?(tor) → review+
Assignee | ||
Comment 6•19 years ago
|
||
Comment on attachment 192196 [details] [diff] [review] layout/svg/renderer part, merged to trunk Qt/Xlib specific patch to allow building with SVG. does not affect the default build.
Attachment #192196 -
Flags: approval1.8b4?
Comment 7•19 years ago
|
||
this eliminates the necessity for the Qt change too, no? At least I don't see why those methods should be virtual.. if at all they should be NS_EXPORT_ but you're using internal API anyway..
Assignee | ||
Comment 8•19 years ago
|
||
well, the qt change is still needed... if it's NS_EXPORT_ don't I need to link against libgfx_qt? (I guess not with the linux linker... hm...)
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 178863 [details] [diff] [review] gfx/src/qt part OK, our component libraries are loaded without RTLD_GLOBAL. and I can't link to libgfx_qt either, because the dynamic linker doesn't find it (presumably components/ isn't in the linker path). so the NS_EXPORT solution doesn't work. given that, is this patch acceptable?
Attachment #178863 -
Flags: review?(zack) → review?(mueller)
Comment 10•19 years ago
|
||
its fine with me, but adding a comment on why a simple inline accessor is virtual wouldn't hurt.
Assignee | ||
Updated•19 years ago
|
Attachment #178863 -
Flags: review?(mueller)
Assignee | ||
Comment 11•19 years ago
|
||
ok, although these are not inline...
Assignee | ||
Updated•19 years ago
|
Attachment #192988 -
Flags: review?(zack)
Comment 12•19 years ago
|
||
Comment on attachment 192988 [details] [diff] [review] gfx/src/qt part, with comment looks good.
Attachment #192988 -
Flags: review?(zack) → review+
Assignee | ||
Comment 13•19 years ago
|
||
Comment on attachment 192988 [details] [diff] [review] gfx/src/qt part, with comment affects only the qt port and is a requirement for using cairo as the svg renderer.
Attachment #192988 -
Flags: approval1.8b4?
Assignee | ||
Comment 14•19 years ago
|
||
Checking in gfx/src/qt/nsDrawingSurfaceQt.h; /cvsroot/mozilla/gfx/src/qt/nsDrawingSurfaceQt.h,v <-- nsDrawingSurfaceQt.h new revision: 1.4; previous revision: 1.3 done Checking in layout/build/Makefile.in; /cvsroot/mozilla/layout/build/Makefile.in,v <-- Makefile.in new revision: 1.128; previous revision: 1.127 done Checking in layout/svg/renderer/src/cairo/Makefile.in; /cvsroot/mozilla/layout/svg/renderer/src/cairo/Makefile.in,v <-- Makefile.in new revision: 1.19; previous revision: 1.18 done Checking in layout/svg/renderer/src/cairo/nsSVGCairoCanvas.cpp; /cvsroot/mozilla/layout/svg/renderer/src/cairo/nsSVGCairoCanvas.cpp,v <-- nsSVGCairoCanvas.cpp new revision: 1.22; previous revision: 1.21 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Flags: blocking1.8b4+
Updated•19 years ago
|
Attachment #192988 -
Flags: approval1.8b4? → approval1.8b4+
Updated•19 years ago
|
Attachment #192196 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 15•19 years ago
|
||
MOZILLA_1_8_BRANCH: Checking in gfx/src/qt/nsDrawingSurfaceQt.h; /cvsroot/mozilla/gfx/src/qt/nsDrawingSurfaceQt.h,v <-- nsDrawingSurfaceQt.h new revision: 1.3.18.1; previous revision: 1.3 done Checking in layout/build/Makefile.in; /cvsroot/mozilla/layout/build/Makefile.in,v <-- Makefile.in new revision: 1.127.8.1; previous revision: 1.127 done Checking in layout/svg/renderer/src/cairo/Makefile.in; /cvsroot/mozilla/layout/svg/renderer/src/cairo/Makefile.in,v <-- Makefile.in new revision: 1.18.6.1; previous revision: 1.18 done Checking in layout/svg/renderer/src/cairo/nsSVGCairoCanvas.cpp; /cvsroot/mozilla/layout/svg/renderer/src/cairo/nsSVGCairoCanvas.cpp,v <-- nsSVGCairoCanvas.cpp new revision: 1.21.4.1; previous revision: 1.21 done
Keywords: fixed1.8
You need to log in
before you can comment on or make changes to this bug.
Description
•