288133 - [FIXr]mozilla SVG build up to 2005032900: xml doctype declaration empty in save page

Status: RESOLVED FIXED

(Core :: XML, defect, P1)

Description

[Heinz Kohl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050329
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050329

DOCTYPE empty after saving complete xml pages using mozilla SVG build up to
2005032900.
(for same file: DOCTYPE is saved correctly when using Firefox 1.0) 

((preparing error messages for Mozilla SVG isn't easier with this error))

Reproducible: Always

Steps to Reproduce:
1.run the appended xml file
2.save page (completely)
3.start saved page will end up as "XML Parsing Error: syntax error" pointing to
an emptied "<!DOCTYPE >"

Actual Results:  
XML Parsing Error

Expected Results:  
correct saving of xml page

Comment 1

[Heinz Kohl]

Attachment: original xml file, save page creating defective xml file

Comment 2

[Heinz Kohl]

XML file is correct, when stored alone
(in the reduced example it is only an XML file, and Firefox isn't showing up the
question of saving all files)

Comment 3

[Anne (:annevk)]

Is this Mozilla Application Suite with SVG enabled specific?

Comment 4

[Jonathan Watt [:jwatt]]

Confirming for trunk suite. The problem doesn't exist for trunk firefox.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Jonathan, it "works in Firefox" because you're comparing apples and oranges. 
The bug only appears in the "web page, complete" mode, which Firefox doesn't
offer for XML files for some reason.

So this is a basic WebBrowserPersist bug...

Comment 6

[Boris Zbarsky [:bzbarsky]]

This broke between 2004-12-15-06 and 2004-12-16-08; probably with the expat
landing.  DOM inspector also shows an empty node where it should show the
doctype, so it looks like doctype node creation in general was broken...  Over
to XML; we should really fix this for 1.8.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Luckily, expat now does all this work for us!

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 183058 [details] [diff] [review]
Proposed patch

Hey, I was about to do that :-/.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183058 [details] [diff] [review]
Proposed patch

Requesting 1.8b2 approval.  This unregresses XML doctype DOM node construction,
mostly by removing code that was doing work that Expat now does...

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 183058 [details] [diff] [review]
Proposed patch

a=asa

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 296359 has been marked as a duplicate of this bug. ***