Closed Bug 288532 Opened 19 years ago Closed 19 years ago

OOM crash [@ XPCConvert::JSErrorToXPCException]

Categories

(Core :: XPConnect, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

(Keywords: crash, memory-leak)

Crash Data

Attachments

(1 obsolete file)

p will leak when jsString's alloc fails
we'll crash when data's alloc fails, which is likely given that this is along 
the OOM codepath:

>	xpc3250.dll!XPCConvert::JSErrorToXPCException(...)  Line 1397	C++
 	xpc3250.dll!xpcWrappedJSErrorReporter(...)  Line 667 + 0x1b	C++
 	js3250.dll!js_ReportOutOfMemory(...)  Line 740 + 0xb	C
Attached patch don't leak and don't crash (obsolete) — Splinter Review
Assignee: dbradley → timeless
Status: NEW → ASSIGNED
Attachment #179228 - Flags: superreview?(rbs)
Attachment #179228 - Flags: review?(dbradley)
Comment on attachment 179228 [details] [diff] [review]
don't leak and don't crash

r=dbradley
Attachment #179228 - Flags: review?(dbradley) → review+
Comment on attachment 179228 [details] [diff] [review]
don't leak and don't crash

sr=rbs
Attachment #179228 - Flags: superreview?(rbs) → superreview+
Comment on attachment 179228 [details] [diff] [review]
don't leak and don't crash

mozilla/js/src/xpconnect/src/xpcconvert.cpp	1.93
Attachment #179228 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
*** Bug 277638 has been marked as a duplicate of this bug. ***
Crash Signature: [@ XPCConvert::JSErrorToXPCException]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: