288823 - Trace-malloc fails to compile on windows

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Frank Wein [:mcsmurf]]

I tried to compile a XULRunner build (i think this bug also happens with a
normal Mozilla or Firefox build) with trace-malloc enabled. First it fails on
PR_EXTERN(void)
NS_TrackAllocation(__ptr_t ptr, FILE *ofp);
in nsTraceMalloc.h and nsTraceMalloc.cpp. This problem can be solved by adding
adding
#ifndef __ptr_t
#define __ptr_t void *
#endif
to the header file.

The second error occours when it executes make libs in tools/trace-malloc/.
There i get the error
make[1]: *** No rule to make target `../../dist/lib/xpcom.lib', needed by `space
trace.exe'.  Stop.
after it has compiled spacetrace.c, spacecategory.c and formdata.c

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This patch makes trace-malloc compile with xulrunner (in general libxul apps),
fixes some general issues with new strict string api and compiling on Windows.
I'm not sure yet if it works so in xulrunner, i only get a empty file when
calling the dump function, but that's another problem.

Comment 2

[Frank Wein [:mcsmurf]]

Comment on attachment 180511 [details] [diff] [review]
Patch


>Index: tools/trace-malloc/Makefile.in
>===================================================================
[...]
>+DEFINES += -DMOZILLA_INTERNAL_API=1

Skip that line, i saw this has been fixed in the meantime (also a little bit
different, but it fixes the issue).

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 180511 [details] [diff] [review]
Patch

>Index: tools/trace-malloc/Makefile.in
>+DEFINES += -DMOZILLA_INTERNAL_API=1

This shouldn't be in the patch.

>Index: tools/trace-malloc/lib/nsTraceMalloc.h
>+#ifdef XP_WIN
>+#define setlinebuf(stream) setvbuf(stream, (char *)NULL, _IOLBF, 0)
>+#endif

Use (stream) inside the function call (although it doesn't really matter in
this case).

>+#ifndef __ptr_t
>+typedef void* __ptr_t;
>+#endif

This won't work if __ptr_t is a typedef.

You should probably just change NS_TrackAllocation to use void* instead.

With those changes, r=dbaron.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

r+, review comments have been addressed.

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 182247 [details] [diff] [review]
Patch 2

Can you give sr on this or should i look for someone else?

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 182247 [details] [diff] [review]
Patch 2

This can be checked in for 1.8b3, it's not part of the default build.

/be

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 182247 [details] [diff] [review]
Patch 2

Checking in toolkit/library/Makefile.in;
/cvsroot/mozilla/toolkit/library/Makefile.in,v	<--  Makefile.in
new revision: 1.14; previous revision: 1.13
done
Checking in tools/trace-malloc/lib/nsTraceMalloc.c;
/cvsroot/mozilla/tools/trace-malloc/lib/nsTraceMalloc.c,v  <--	nsTraceMalloc.c
new revision: 1.51; previous revision: 1.50
done
Checking in tools/trace-malloc/lib/nsTraceMalloc.h;
/cvsroot/mozilla/tools/trace-malloc/lib/nsTraceMalloc.h,v  <--	nsTraceMalloc.h
new revision: 1.19; previous revision: 1.18
done

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 182247 [details] [diff] [review]
Patch 2

Checking in Makefile.in;
/cvsroot/mozilla/Makefile.in,v	<--  Makefile.in
new revision: 1.294; previous revision: 1.293
done