289059 - AIX GTK2 build fails to link after checkin for Bug 280725

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Philip K. Warren]

The checkin for Bug 280725 added a dependency on the X11 libraries on the
toolkit/components/remote library. Since -lX11 isn't included in the pkg-config
output for gtk2 on AIX, it is necessary to explicitly link against X11 libraries
to resolve all of the necessary symbols.

This is similar to Bug 236836, which was fixed for mozilla-bin.

Comment 1

[Philip K. Warren]

Attachment: Patch v1

This fixes the error by adding an explicit dependency on the X11 libraries when
linking this shared library.

Comment 2

[Benjamin Smedberg]

Comment on attachment 179657 [details] [diff] [review]
Patch v1

Urgh. Oh well.

Comment 3

[Philip K. Warren]

Fixed.

Checking in Makefile.in;
/cvsroot/mozilla/toolkit/components/remote/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

ifdef MOZ_X11?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

hrm, that's not in autoconf.mk.in, although configure.in does AC_SUBST(MOZ_X11)...