289179 - pgup/pgdown no longer work in textareas

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from 2005-04-03-06 to 2005-04-04-06.  To reproduce:

1)  Load https://bugzilla.mozilla.org/attachment.cgi?id=179734&action=edit
2)  Click the "Edit Attachment As Comment" button.
3)  Focus the textarea
4)  Hit the "Page down" key.

ACTUAL RESULTS:  Nothing happens

EXPECTED RESULTS: Page down.

This looks somewhat similar to bug 289022, so marking dependent.  In any case,
the scrollframe changes are my initial culprit for this regression.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(Also worth testing Shift-PgUp and Shift-PgDn.  It seems a little odd that
something like the scrollframe changes would brake only a subset of keys, so
that may not be the cause.)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Just another place making assumptions about scrollframe internals. In this
case, nsTextControlFrame was actually assuming that the scrollframe's scrolling
view was the view for its first child frame.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 179789 [details] [diff] [review]
fix

r+sr=dbaron, but since this comes first:

>   first->AddStateBits(NS_FRAME_REFLOW_ROOT);

you clearly don't need any null-checks of |first|.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 179789 [details] [diff] [review]
fix

approving since this didn't make it in yesterday.  Please do try to get this in
soon.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.