289248 - content window gets no scrollbars

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew Schultz]

With a seamonkey gtk2 build, pages do not get scrollbars even if the window is
too small.  I saw this with a build from 19:54 PDT and 18:32 PDT, but not 16:50
PDT indicating the checkin from 286000 caused this.

I could not reproduce the problem with a firefox gtk2 build from 23:11 PDT

Comment 1

[Charles Fenwick]

Saw this on Seamonkey at the same time Andrew did.

Unlike Andrew, however, I am also seeing this on Firefox GTK2 build (checkout
started 23:15 PDT)

Comment 2

[Doug Halamay]

I saw this problem in a just-pulled Firefox build (1am PDT, 4/6/05) on WinXP SP2.

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050406
Firefox/1.0+

Confirming on Win
?1.1

Comment 4

[Tobias Fischer]

*** Bug 289273 has been marked as a duplicate of this bug. ***

Comment 5

[Andrew Schultz]

Valgrind is seeing this:

Conditional jump or move depends on uninitialised value(s)
 nsCSSFrameConstructor::CreateAnonymousFrames() (nsCSSFrameConstructor.cpp:5660)
 nsCSSFrameConstructor::BeginBuildingScrollFrame() (nsCSSFrameConstructor.cpp:6307)
 nsCSSFrameConstructor::ConstructRootFrame() (nsCSSFrameConstructor.cpp:4622)
 PresShell::InitialReflow() (nsPresShell.cpp:2810)
 nsContentSink::StartLayout() (nsContentSink.cpp:921)
 HTMLContentSink::StartLayout() (nsHTMLContentSink.cpp:3661)
 HTMLContentSink::OpenBody() (nsHTMLContentSink.cpp:2774)
 CNavDTD::OpenBody() (CNavDTD.cpp:3021)
 CNavDTD::OpenContainer() (CNavDTD.cpp:3250)
 CNavDTD::HandleDefaultStartToken() (CNavDTD.cpp:1316)
 CNavDTD::HandleStartToken() (CNavDTD.cpp:1695)
 CNavDTD::HandleToken() (CNavDTD.cpp:938)

I added this:
           aParent->GetNodeInfo() &&
           aParent->GetNodeInfo()->Equals(nsSVGAtoms::use, kNameSpaceID_SVG))
        bindingParent = aParent;
 #endif
       rv = content->BindToTree(aDocument, aParent, bindingParent, PR_TRUE);
+      fprintf (stdout, "rv=%d\n", rv);
       if (NS_FAILED(rv)) {
         content->UnbindFromTree();
         return rv;
       }

the first call returned rv = 5354252.  I added "rv=14;" before the call to
BindToTree, and it "works" now.  rv=0 always and I have scrollbars.  That smells
like a compiler bug, but that wouldn't explain someone seeing this on WinXP...

Comment 6

[Steve England [:stevee]]

*** Bug 289293 has been marked as a duplicate of this bug. ***

Comment 7

[:Mook]

Attachment: Patch (untested)

I presume only non-SVG builds are seeing this?

If MOZ_SVG is not defined, and any of the applicable if statements are true in
the MOZ_XUL and MOZ_XTF sections, then rv is never set since it effectively
falls into the else clause.

In the patch the additional |bindingParent = content;| effectively does
nothing, but that's the easiest way I can think of without using empty
statements.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179850 [details] [diff] [review]
Patch (untested)

Mook, nice catch!  And yes, all my builds were SVG builds....

This isn't quite the approach I think we should take here, though.  Different
patch coming up.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

I think an empty block (with corresponding comment) is actually clearer here
(and lets me make the svg block like the others to prevent this from happening
again).

Comment 10

[Mike Shaver (:shaver emeritus)]

Comment on attachment 179856 [details] [diff] [review]
Patch

r+sr+a=shaver for 1.1a checkin so that we work even without SVG.

Comment 11

[Mike Shaver (:shaver emeritus)]

Comment on attachment 179856 [details] [diff] [review]
Patch

Sorry, I meant 1.8b2, which I think eventually leads to 1.1a, but really...

Comment 12

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.  Thanks for figuring out what the problem was, guys!  And my
apologies for the trouble.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Oh, and people might want to remove the blocking nominations from this bug....

Comment 14

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050406
Firefox/1.0+ 10:18 PDT

verified on FF/Win

Comment 15

[Scott MacGregor]

*** Bug 289342 has been marked as a duplicate of this bug. ***

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 289350 has been marked as a duplicate of this bug. ***

Comment 17

[Tuukka Tolvanen (sp3000)]

*** Bug 289408 has been marked as a duplicate of this bug. ***

Comment 18

[Carsten Book [:Tomcat]]

*** Bug 289466 has been marked as a duplicate of this bug. ***