289376 - Fix description and value for combo boxes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Both XUL and HTML combobox descriptions should provide positional information in
MSAA. This is the same as the "n of m" descriptions found on the options themselves.

Also, the value of of the HTML option reported after a value change event is
currently for the old option.

Comment 1

[Aaron Leventhal]

Attachment: 1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

Comment 2

[Louie Zhao]

Comment on attachment 179907 [details] [diff] [review]
1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

The patch looks good for me.

BTW, on ATK, most accessibles (including those for the items of XUL/HTML
combobox) have no description because it doesn't contain special info like "n
of m".

Comment 3

[Aaron Leventhal]

(In reply to comment #2)
> (From update of attachment 179907 [details] [diff] [review] [edit])
> The patch looks good for me.
> 
> BTW, on ATK, most accessibles (including those for the items of XUL/HTML
> combobox) have no description because it doesn't contain special info like "n
> of m".
> 

Right, so in the end this won't generally affect ATK because the option
description is just forwarded. I didn't want to create a special ns*ComboBoxWrap
classes for the combo boxes in MSAA just for this patch, just for one method.

Comment 4

[Aaron Leventhal]

*** Bug 289314 has been marked as a duplicate of this bug. ***

Comment 5

[Aaron Leventhal]

Comment on attachment 179907 [details] [diff] [review]
1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

No response from jst after 1 month.

Comment 6

[[e-mail]]

Comment on attachment 179907 [details] [diff] [review]
1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

>+		  uriloader \
Oversight?

>@@ -2464,13 +2464,13 @@ nsComboboxControlFrame::OnOptionSelected
>     if (aSelected) {
>       RedisplayText(aIndex);
>-      FireValueChangeEvent();
>     } else {
>       RedisplaySelectedText();
>+      FireValueChangeEvent(); // Fire after old option is unselected
>     }
Perhaps it would help to fire the event from within
nsHTMLSelectElement::SetOptionsSelectedByIndex instead?

Comment 7

[Aaron Leventhal]

Comment on attachment 179907 [details] [diff] [review]
1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

I'll check into Neil's 2 questions.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 179907 [details] [diff] [review]
1) Forward focused option's description through combo box, 2) In HTML use focused 's label for combo box value, 3) Fire ValueChange event after old selection option unselected

a=asa

Comment 9

[Aaron Leventhal]

(In reply to comment #6)
> Perhaps it would help to fire the event from within
> nsHTMLSelectElement::SetOptionsSelectedByIndex instead?

I only want to do this for closed comboboxes, not listboxes (either size >1 or
open combo boxes). While this may be doable from SetOptionsSelectedByIndex, I
think it's not necessary to attempt this change at this stage of trunk development.

Comment 10

[Aaron Leventhal]

Checking in accessible/src/xul/nsXULSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.cpp,v  <-- 
nsXULSelectAccessible.cpp
new revision: 1.26; previous revision: 1.25
done
Checking in accessible/src/xul/nsXULSelectAccessible.h;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.h,v  <-- 
nsXULSelectAccessible.h
new revision: 1.20; previous revision: 1.19
done
Checking in accessible/src/html/nsHTMLSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp,v  <-- 
nsHTMLSelectAccessible.cpp
new revision: 1.44; previous revision: 1.43
done
Checking in accessible/src/html/nsHTMLSelectAccessible.h;
/cvsroot/mozilla/accessible/src/html/nsHTMLSelectAccessible.h,v  <-- 
nsHTMLSelectAccessible.h
new revision: 1.26; previous revision: 1.25
done
Checking in layout/forms/nsComboboxControlFrame.cpp;
/cvsroot/mozilla/layout/forms/nsComboboxControlFrame.cpp,v  <-- 
nsComboboxControlFrame.cpp
new revision: 1.318; previous revision: 1.317
done

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381