289377 - Bogus code in nsCSSFrameConstructor seems to be unused

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

If you look in RecreateFramesForContent here:
http://lxr.mozilla.org/mozilla/source/layout/base/nsCSSFrameConstructor.cpp#11622
you'll notice that 'parent' is always null, and the value of 'frame' is unused.
Indeed, digging through CVS blame, a couple of years ago I changed "parent =" to
"frame =" during deCOMtamination. No-one's noticed any bugs due to this since,
certainly not with scrollbar parenting which is why I introduced this code in
the first place (switching to listboxes/comboboxes to nsGfxScrollFrame). So I
say we just rip it out.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

In fact we don't need that parameter to ContentInserted at all.

Note that this is risk-free since we're not changing the behaviour at all. The
only risk is that two years ago I introduced a bug that's still out there that
might be fixed if we re-enabled this code. I doubt it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 179911 [details] [diff] [review]
fix

r+sr=bzbarsky.	This was probably meant as an optimization, but I doubt that
it's worth it even then.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in