289489 - qfa broken in latest trunk builds due to API/build config change

Status: RESOLVED FIXED

(Core Graveyard :: Talkback Client, defect)

Description

[Chase Phillips]

Based on the build log files, it appears the QFA was broken by a recent check-in
to the code.  When the code builds correctly, the output appears as:

==========================================
Building deps for nsQfaServicesFactory.cpp
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/build/cygwin-wrapper
cl -FonsQfaServicesFactory.obj -c  -D_IMPL_NS_GFX -D_IMPL_NS_MSG_BASE
-D_IMPL_NS_WIDGET  -DOSTYPE=\"WINNT5.0\" -DOSARCH=\"WINNT\"
-DBUILD_ID=2005040506  -I../../../dist/include/xpcom
-I../../../dist/include/mozcomps -I../../../dist/include/embedcomponents
-I../../../dist/include/fullsoft -I../../../dist/include/string
-I../../../dist/include/qfaservices -I../../../dist/include
-I../../../dist/include/nspr   
-I/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/include       
-TP -nologo -W3 -Gy -Fdqfaservices.pdb  -DNDEBUG -DTRIMMED -Zi -O1 -UDEBUG
-DNDEBUG -MD            -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.8b2\"
-DMOZILLA_VERSION_MAJOR=1 -DMOZILLA_VERSION_MINOR=8 -DHAVE_SNPRINTF=1
-D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1
-DWINVER=0x400 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1
-DD_INO=d_ino -DMOZ_DEFAULT_TOOLKIT=\"window!
 s\" -DMOZ_P
HOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1
-DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1 -DMOZ_MATHML=1
-DMOZ_LOGGING=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1
-DMOZ_BYPASS_PROFILE_AT_STARTUP=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1
-DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZILLA_LOCALE_VERSION=\"1.8b2\"
-DMOZILLA_REGION_VERSION=\"1.8b2\" -DMOZILLA_SKIN_VERSION=\"1.5\" 
-D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/fullsoft/qfa/src/nsQfaServicesFactory.cpp
nsQfaServicesFactory.cpp
/usr/bin/perl
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/config/version_win.pl
-QUIET 1 -DEPTH ../../.. -TOPSRCDIR
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla -BITS 32 -OBJDIR
. -SRCDIR
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/fullsoft/qfa/src
-OFFICIAL 1 -MODNAME qfaservices
Creating Resource file: module.res
==========================================

Currently, the code is failing to compile with the error:

==========================================
Building deps for nsQfaServicesFactory.cpp
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/build/cygwin-wrapper
cl -FonsQfaServicesFactory.obj -c  -D_IMPL_NS_GFX -D_IMPL_NS_MSG_BASE
-D_IMPL_NS_WIDGET  -DOSTYPE=\"WINNT5.0\" -DOSARCH=\"WINNT\"
-DBUILD_ID=2005040706  -I../../../dist/include/xpcom
-I../../../dist/include/mozcomps -I../../../dist/include/embedcomponents
-I../../../dist/include/fullsoft -I../../../dist/include/string
-I../../../dist/include/qfaservices -I../../../dist/include
-I../../../dist/include/nspr    -I../../../dist/sdk/include
-I/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/include       
-TP -nologo -W3 -Gy -Fdqfaservices.pdb  -DNDEBUG -DTRIMMED -Zi -O1 -UDEBUG
-DNDEBUG -MD            -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.8b2\"
-DMOZILLA_VERSION_MAJOR=1 -DMOZILLA_VERSION_MINOR=8 -DHAVE_SNPRINTF=1
-D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1
-DWINVER=0x400 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1
-DD_INO=d_ino -D!
 MOZ_DEFAULT
_TOOLKIT=\"windows\" -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1
-DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1 -DMOZ_MATHML=1
-DMOZ_LOGGING=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1
-DMOZ_BYPASS_PROFILE_AT_STARTUP=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1
-DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZILLA_LOCALE_VERSION=\"1.8b2\"
-DMOZILLA_REGION_VERSION=\"1.8b2\" -DMOZILLA_SKIN_VERSION=\"1.5\" 
-D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT
/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/fullsoft/qfa/src/nsQfaServicesFactory.cpp
nsQfaServicesFactory.cpp
NEXT ERROR
c:/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/fullsoft/qfa/src/nsQfaServicesFactory.cpp(58)
: error C2065: 'do_GetService' : undeclared identifier
make[3]: *** [nsQfaServicesFactory.obj] Error 2
make[3]: Leaving directory
`/cygdrive/c/builds/tinderbox/Fx-Trunk/WINNT_5.0_Depend/mozilla/fullsoft/qfa/src'
==========================================

The most likely cause of this is
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=bsmedberg%25covad.net&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-05+20%3A35&maxdate=2005-04-05+20%3A35&cvsroot=%2Fcvsroot

Based on feedback from dbaron, the Makefile for QFA needs to set
MOZILLA_INTERNAL_API to 1 to get access to the API functions it assumes will be
present.

The talkback client hasn't been in our trunk builds for a couple of days from
what I hear.  Hopefully we've at least tracked the problem down.

Comment 1

[sairuh (rarely reading bugmail)]

aha, found the Talkback component --as this affects both Firefox and Thunderbird.

Comment 2

[Chase Phillips]

Attachment: patch qfa Makefile.in to support opt-in for internal API

Comment 3

[Darin Fisher]

Comment on attachment 179992 [details] [diff] [review]
patch qfa Makefile.in to support opt-in for internal API

sr=darin

Comment 4

[Chase Phillips]

Comment on attachment 179992 [details] [diff] [review]
patch qfa Makefile.in to support opt-in for internal API

Landed this on the trunk.  Will respin beast soon to try the fix out.

Comment 5

[Chase Phillips]

Hmm.  I thought MOZILLA_INTERNAL_API=1 would be enough, though it didn't
obviously fix the build problem.  Any ideas why?

Comment 6

[Darin Fisher]

Same build error?  Did the compile line change at all?

Comment 7

[Scott MacGregor]

is the error the same chase? I can't find the build log from the beast build. I
can wait until tomorrow's builds are done and look at those logs easily enough
from tinderbox.

Also, I don't think you are defining the new build flag in the right spot. Try
putting your Makefile.in change in the Makefile.in file under
mozilla\fullsoft\qfa\src\Makefile.in

Comment 8

[Chase Phillips]

(In reply to comment #6)
> Same build error?

The error is the same.  See http://tinderbox.mozilla.org/sb.cgi?tree=Firefox,
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1112922960.30405.gz&fulltext=1.

> Did the compile line change at all?

No, it didn't.

(In reply to comment #7)
> Also, I don't think you are defining the new build flag in the right spot. Try
> putting your Makefile.in change in the Makefile.in file under
> mozilla\fullsoft\qfa\src\Makefile.in

Urk.  I assumed MOZILLA_INTERNAL_API would've propagated down to
fullsoft/qfa/src/ but maybe not how I thought.

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #8)
> (In reply to comment #7)
> > Also, I don't think you are defining the new build flag in the right spot. Try
> > putting your Makefile.in change in the Makefile.in file under
> > mozilla\fullsoft\qfa\src\Makefile.in
> 
> Urk.  I assumed MOZILLA_INTERNAL_API would've propagated down to
> fullsoft/qfa/src/ but maybe not how I thought.

Generally things don't propagate that way.

Comment 10

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050408
Build ID: 2005040805 is missing qfaservices.dll and master.ini 

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It would probably be good to back out the previous fix.

Also, it's not actually using the internal API.  It's just depending on
nsIServiceManager.h including nsServiceManagerUtils.h, which it doesn't in the
strict API.  We're probably better adding the include and trying to make the
talkback component use the strict API so that it's less likely to be broken.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

This also fixes a gcc 3.4 compilation error (extra semicolon).

Comment 13

[Chase Phillips]

Comment on attachment 180095 [details] [diff] [review]
patch

I'm testing this patch out on beast now.

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in.

Comment 15

[Jay Patel [:jay]]

v.fixed on Win32 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050408 Firefox/1.0+

Comment 16

[Jay Patel [:jay]]

Reopening for further investigation. It looks like today's builds ran into the
same problem:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1113246840.10787.gz&fulltext=1

Comment 17

[Jay Patel [:jay]]

Chase told me this was not a regression...returning to fixed.  Sorry for the spam.

Comment 18

[Chase Phillips]

(In reply to comment #16)
> Reopening for further investigation. It looks like today's builds ran into the
> same problem:
>
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1113246840.10787.gz&fulltext=1

The link above is to a build log which wasn't a release cycle so doesn't build
with the talkback client.  The warnings you see in it are related to the fact
that the talkback client files were built during an earlier release cycle and
the files are still around throughout the later dep release cycles.  The
warnings classify those extra files as "unnecessary."  You can safely ignore them.

Some of today's release builds were missing the Talkback client because of a
connection refused error from the Talkback server, which appears to have been
one of a network glitch, a http server glitch, or a database server glitch.  I'm
not sure which.