289609 - Dynamically changing the favicon doesn't update the icon in the tab.

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

SeaMonkey version of bug 289553

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5)
Gecko/20041111 Firefox/1.0
> Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5)
Gecko/20041111 Firefox/1.0
> 
> If you dynamically update the favicon by removing/re-adding a rel="icon" link in
> the head the icon in the tab doesn't update. It does however update in the
> location bar. See the URL for an example.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Make sure you have more than one tab (so tabs are visible)
> 2. Load http://people.redhat.com/~alexl/files/dynfavicon.html
> 3. click on "changed icon" button
> 
> 
> Actual Results:  
> favicon changed in location entry (next to url), but not in the tab.
> 
> Expected Results:  
> Icon should have changed in the tab too.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Neil said he has a patch that works.

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

This fixes this bug, and should also make the URL bar favicon update properly
when you switch tabs.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 180286 [details] [diff] [review]
patch

a=asa

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot with post-fixed build

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-04-18-05, Windows XP Seamonkey trunk.