289706 - E4X: contains called on complex XML object with a simple string argument yields true but should yield false

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Martin Honnen]

The following test case

var gods = <gods>
  <god>Kibo</god>
  <god>Xibo</god>
</gods>;

print('XML markup is:\r\n' + gods.toXMLString());

var string = 'Kibo';
print('gods.contains(\'' + string + '\'): ' + gods.contains(string));
print('gods == \'' + string + '\': ' + (gods == string));

when run in the Spidermonkey shell (as pulled today via CVS) outputs:

XML markup is:
<gods>
  <god>Kibo</god>
  <god>Xibo</god>
</gods>
gods.contains('Kibo'): true
gods == 'Kibo': false

while the result should be

XML markup is:
<gods>
  <god>Kibo</god>
  <god>Xibo</god>
</gods>
gods.contains('Kibo'): false
gods == 'Kibo': false

as the E4X specification says about the contains method in section 13.4.4.10:
  "Return the result of the comparison x == value"
where the comparison operation == is specified in section 11.5.1 so the result
of the contains call should be the same as the result of the comparison, it
should be false.

Comment 1

[Brendan Eich [:brendan]]

Oops, looks like missing logic in Equals (jsxml.c).

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

See ECMA-357 9.{1,2}.1.9 [[Equals]].  E4X is a 1.8 required feature, so I'm
self-approving and checking in trivial fixes.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed.  Thanks, Martin!

/be

Comment 4

[Bob Clary [:bc] (inactive)]

added to test library
Checking in 13.4.4.10.js;
/cvsroot/mozilla/js/tests/e4x/XML/13.4.4.10.js,v  <--  13.4.4.10.js
new revision: 1.4; previous revision: 1.3