289838 - "Search Messages" in Mail Account Context Menu is broken (always disabled)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Carsten Book [:Tomcat]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050410
Mnenhy/0.7.2.0

It`s no longer possible to use the "Search Messages" function in the Context
Menu.The Function is not clickable.

It only works in Tools -> Search Messages.

To reproduce:
1. Open MailNews
2. Click right in your local Mail Account or Local Folders and try to click on
"Search Messages"
3. Nothing happens/Function not clickable

Regressed between 050405 and 050406.

Comment 1

[Ian Neal]

There are a few solutions to this problem and here are a couple:
a) Alter
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailWindowOverlay.xul#658
from:
<popup id="folderPaneContext" onpopupshowing="return fillFolderPaneContextMenu();"
to the following line:
<popup id="folderPaneContext" onpopupshowing="goUpdateCommand('cmd_search');
return fillFolderPaneContextMenu();"

b) Alter
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailWindowOverlay.xul#717
from:
    command="cmd_search"/>
to the following line:
    oncommand="MsgSearchMessages();"/>
and probably remove references to cmd_search elsewhere.

Comment 2

[Ian Neal]

Attachment: Patch v0.1

This patch:
* Moves cmd_search from "mailCommands" commandset to "mailToolsMenuItems" one.
* Changes mailContextMenus.js to update "cmd_search" rather than menuitem.
* Makes Tool menuitem and key use "cmd_search" too, so they are
enabled/disabled correctly.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 289986 has been marked as a duplicate of this bug. ***

Comment 4

[[e-mail]]

Comment on attachment 180360 [details] [diff] [review]
Patch v0.1

>+  <command id="cmd_search" oncommand="goDoCommand('cmd_search')" disabled="true"/>
I wonder why this had disabled="true" on it, after all it's not usually
disabled, is it? (Although, nobody would have noticed the bug if it hadn't said
disabled!)

Comment 5

[Ian Neal]

Attachment: Tweaked Patch v0.1a (Checked in)

Changes from v0.1
* Removed disabled="true" from cmd_search

Carrying forward r and sr, requesting a= for low risk, regression fix.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 181067 [details] [diff] [review]
Tweaked Patch v0.1a (Checked in)

a=asa

Comment 7

[Ian Neal]

Comment on attachment 181067 [details] [diff] [review]
Tweaked Patch v0.1a (Checked in)

Checking in mailContextMenus.js;
/cvsroot/mozilla/mailnews/base/resources/content/mailContextMenus.js,v	<-- 
mailContextMenus.js
new revision: 1.53; previous revision: 1.52
done
Checking in mailWindowOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.xul,v  <-- 
mailWindowOverlay.xul
new revision: 1.292; previous revision: 1.291
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-04-21-06 under Windows XP with Seamonkey trunk.

I checked both IMAP and Local/POP3 folders.