289843 - webbrowserpersist should release reference to listener at some time

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

currently, webbrowserpersist never releases the reference to its listener
(unless SetProgressListener is called). that sucks because the listener may well
hold a reference to wbp in order to call cancelSave(). wbp should probably null
it out in onStopRequest or somesuch.

Comment 1

[Boris Zbarsky [:bzbarsky]]

biesi, want to just post a patch?  I doubt Adam plans to look at this any time
soon....

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Darin Fisher]

Comment on attachment 181724 [details] [diff] [review]
patch

The code is ok with mProgressListener being null after this point, right?  i
presume so, just want to be make sure ;)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 181724 [details] [diff] [review]
patch

yes; and webbrowserpersist nullchecks every use of mProgressListener (not all
users might set a listener)

This patch fixes a potential memory leak, should be low risk

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 181724 [details] [diff] [review]
patch

a=asa

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v
 <--  nsWebBrowserPersist.cpp
new revision: 1.109; previous revision: 1.108
done