289975 - Crash when using display:-moz-page-break

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[Martijn Wargers (dead)]

Follow-up from bug 289967.
The url testcase uses display:-moz-page-break;
This hangs/crashes current trunk build of Mozilla.
This did not crash with Mozilla build 2004102604.
It crashes with Mozilla build 2004102705.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So is there a reason we have this DISPLAY_PAGE_BREAK thing for page-break
frames?  Can't we just make them display:inline (or even display:none, but that
could be a little weird)?

If we really need the separate display value, we probably just need to fix
ConstructFrameByDisplay to return null for it.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Your guess is as good as mine...

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK, I tested using display:block (since those are basically replaced-element
blocks), and that works fine.  I plan to do just that once the patch for bug
289967 lands (otherwise I'll end up with self-conflicts).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the testcase at
https://bugzilla.mozilla.org/attachment.cgi?id=180422 with build 2005-04-23-05
on Windows XP: no more crash here.