290102 - Windows widget code can call OnPaint from Invalidate

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This can happen when we're in translucent window mode. This is bad because we
assume elsewhere that it's OK to call Invalidate while painting.

The long term solution is to defer the OnPaint call via an internal event. The
short term solution is to add a flag to the nsWindow structure to detect
recursive entry of OnPaint and bail out if we try to reenter while OnPaint is
already running. It should also print a warning so we know when this happens.

Comment 1

[Stuart Parmenter]

Attachment: fix the stack overflow and transparency problems

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181232 [details] [diff] [review]
fix the stack overflow and transparency problems

This fix for a crasher regression needs to go in.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in. thanks

Comment 4

[Tracy Walker [:tracy]]

the crash from bug 290988 is fixed as seen on Windows Firefox and Thunderbird
builds 04/22.  But the transparent Options dialog is still present with
non-default themes. 

Was the patch also meant to fix the transparency issue?  Should a different bug
be logged?  If this is the right bug for this issue, then this bug needs to be
reopened, upgraded to blocker and nominated for blocking 1.1

Comment 5

[Boris Zbarsky [:bzbarsky]]

> Was the patch also meant to fix the transparency issue?

No.

> Should a different bug be logged?

Yes.

> If this is the right bug for this issue,

It's not.

Comment 6

[Tracy Walker [:tracy]]

okay, thanks. Filed bug 291484 for the Options dialog transparency issue.