290239 - various hazards in do_CreateInstanceFromCategory

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Shaver (:shaver emeritus)]

1) mOuter is never initialized, so you always end up trying to aggregate against
a random stack pointer.
2) we test rv after performing the createInstance in operator(), but don't
actually set it based on that call
3) unconditionally store through mErrorPtr, though it can trivially be null.

Patch coming up for these woes.

(No wonder nobody uses it!)

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: 3 fixes

All of these are my bugs, natch.

Comment 2

[Benjamin Smedberg]

Comment on attachment 180638 [details] [diff] [review]
3 fixes

I'm not an XPCOM peer, so darin or dougt needs to review also.

Comment 3

[Darin Fisher]

Comment on attachment 180638 [details] [diff] [review]
3 fixes

>Index: components/nsComponentManager.cpp

>+    rv = compMgr->CreateInstanceByContractID(value,
>                                         mOuter,
>                                         aIID,
>                                         aInstancePtr);

nit: please fix parameter alignment while here.

sr=darin

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 180638 [details] [diff] [review]
3 fixes

a=brendan for 1.8b2.

/be

Comment 5

[Mike Shaver (:shaver emeritus)]

Fixed, thanks all for speedy reviews.