Closed Bug 290429 Opened 19 years ago Closed 19 years ago

missing |this.| in error case results in code that will never work

Categories

(Core Graveyard :: Error Console, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: ajschult784)

References

()

Details

Attachments

(1 file)

JavaScript error: chrome://global/content/consoleBindings.xml, line 82: 
appendMessage is not defined
Attached patch the patchSplinter Review
Assignee: timeless → ajschult
Status: NEW → ASSIGNED
Attachment #180775 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180775 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 180775 [details] [diff] [review]
the patch

For a moment there I thought this was my fault but in fact I'd just searched
and replaced existing faulty code, phew!
Attachment #180775 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180775 - Flags: superreview+
Attachment #180775 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #180775 - Flags: review+
Comment on attachment 180775 [details] [diff] [review]
the patch

really really low risk.  fixes error handling.
Attachment #180775 - Flags: approval1.8b2?
Comment on attachment 180775 [details] [diff] [review]
the patch

a=caillon
Attachment #180775 - Flags: approval1.8b2? → approval1.8b2+
fixed
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
Product: SeaMonkey → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: