290752 - Style context parentage warnings with scrollframes

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Start currrent debug build
2)  Hover the URL bar a few times

ACTUAL RESULTS:

frame: Area(div)(-1) (0x860520c) style: 0x8605178 :-moz-scrolled-content {}
Wrong parent style context:  style: 0x86050e4 :-moz-scrolled-content {}
should be using:  style: 0x85f4de4 {}

EXPECTED RESULTS:

No warnings.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I'm guessing that the problem is that GetStyleContextParent() isn't returning
the thing we use as the parent in the frame constructor somewhere, but I don't
know where...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I thought I saw this before, but I can't reproduce it right now.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm... Hovering over the url bar (classic theme) reproduces quite reliably...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We were creating an extra, unnecessary level of style contexts there.

The only issue is that we want the root scrolled frame to have both
-moz-scrolled-content and -moz-canvas (or -moz-page-sequence) pseudos. I've
solved this by introducing -moz-scrolled-canvas and -moz-scrolled-page-sequence
and arranging for ua.css to give them the union of the style rules. Maybe
there's a better way...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 181932 [details] [diff] [review]
fix

No, this looks reasonable...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181932 [details] [diff] [review]
fix

Fixes annoying warning spam on the console (regression) which people have been
complaining about

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 181932 [details] [diff] [review]
fix

a=asa

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in