290788 - crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments]

Status: VERIFIED FIXED

(MailNews Core :: Attachments, defect)

Description

[Tobias Fischer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Mnenhy/0.7.2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Mnenhy/0.7.2.0

Mozilla is crashing imediatly when I try to save two attached Files (Word.doc)
from Mail while using the Menu from MailNews-Client 'File' 'Attachments' 'Save all'.

When I try this, Filebrowser opens, I would like to save Files in this
Directory, so i don't browse further. 

Reproducible: Always

Steps to Reproduce:
1. Start MailNews
2. Mark Message with attached Files 
3. Choose 'Save All' from Client => File => Attachments Menu

Actual Results:  
Mozilla crashes

Expected Results:  
Just save the Files.

Got an Talkback-ID: TB5169274X

and add TB-Stack: 

nsMessenger::SaveAllAttachments 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/src/nsMessenger.cpp,
line 918]
nsMessenger::SaveAllAttachments 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/src/nsMessenger.cpp,
line 861]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2065]
XPC_WN_CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1287]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1320]
js_Interpret 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 3595]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1340]
js_Interpret 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 3595]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1340]
js_InternalInvoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1417]
JS_CallFunctionValue 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsapi.c, line
3804]
nsJSContext::CallEventHandler 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 1384]
nsJSEventListener::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/events/nsJSEventListener.cpp,
line 184]
nsEventListenerManager::HandleEventSubType 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1545]
nsEventListenerManager::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/events/src/nsEventListenerManager.cpp,
line 1642]
nsXULElement::HandleDOMEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/xul/content/src/nsXULElement.cpp,
line 2194]
PresShell::HandleDOMEventWithTarget 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 6396]
nsMenuFrame::Execute 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsMenuFrame.cpp,
line 1629]
nsMenuFrame::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsMenuFrame.cpp,
line 453]
PresShell::HandleEventInternal 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 6361]
PresShell::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/base/nsPresShell.cpp,
line 6142]
nsViewManager::HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 2498]
nsViewManager::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsViewManager.cpp,
line 2220]
HandleEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 174]
nsWindow::DispatchEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1179]
nsWindow::DispatchMouseEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 5895]
ChildWindow::DispatchMouseEvent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 6148]
nsWindow::WindowProc 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsWindow.cpp,
line 1471]
USER32.dll + 0x8734 (0x77d18734)
USER32.dll + 0x8816 (0x77d18816)
USER32.dll + 0x89cd (0x77d189cd)
USER32.dll + 0x8a10 (0x77d18a10)
nsAppShell::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsAppShell.cpp,
line 159]
nsAppStartup::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/components/startup/src/nsAppStartup.cpp,
line 208]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1752]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1776]
kernel32.dll + 0x16d4f (0x7c816d4f)

Comment 1

[Tobias Fischer]

Hartmut Figge, one of our Seamonkey-Testers, have reproduced the crash with an
yesterdays Linux-Build, posting in Newsgroup d.c.s.m.nb
<[e-mail]> 

In Reason of that, I change 'OS' to 'All'. 

Also, this crash is at Moment on Place 35 of Talkback Topcrasher List, maybe we
should add the Keyword 'topcrash'.

Comment 2

[Ruediger Lahl]

(In reply to comment #1)
> Hartmut Figge, one of our Seamonkey-Testers, have reproduced the crash with an
> yesterdays Linux-Build, posting in Newsgroup d.c.s.m.nb
> <[e-mail]> 
> 
> In Reason of that, I change 'OS' to 'All'. 

I can reproduce the crash also on my msvc-build 2005041803.

> Also, this crash is at Moment on Place 35 of Talkback Topcrasher List, maybe we
> should add the Keyword 'topcrash'.

ACK.

Comment 3

[Frank Wein [:mcsmurf]]

Neil: This is a regression from your checkin for Bug 2920, the UI part (checkin
into msgHdrViewOverlay.js and msgHdrViewOverlay.xul). We end up with all the
arrays (attachmentUrlArray, attachmentContentTypeArray,
attachmentDisplayNameArray, attachmentMessageUriArray) having length 0.
selectedAttachments is of type void and doesn't seem to include anything.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch

Neil: Easy fix, you forgot an arg ;-).

Comment 5

[[e-mail]]

Comment on attachment 181152 [details] [diff] [review]
Patch

D'oh! ;-)

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 181152 [details] [diff] [review]
Patch

a=asa

Comment 7

[Frank Wein [:mcsmurf]]

Checked in:
2005-04-20 09:51	timeless%mozdev.org 	mozilla/ mailnews/ base/ resources/
content/ msgHdrViewOverlay.xul 	1.64 	3/3  	Bug 290788 crash when try to 'save
all' Attachments from MailNews 'File' 'Attachments' Menu [@
nsMessenger::SaveAllAttachments] patch by [e-mail] r=neil sr=neil a=asa

Comment 8

[Tobias Fischer]

Using Creature-Tinderbox-Build 2005042012 'Save All' Attachments works fine, no
crash. Think this could be marked as 'Verified Fixed' now.
Thanks for your fast work. 

Comment 9

[Frank Wein [:mcsmurf]]

V.