Closed Bug 290850 Opened 20 years ago Closed 20 years ago

BUILD_ID uses $(shell) poorly

Categories

(Firefox Build System :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: benjamin, Assigned: darin.moz)

Details

Attachments

(1 file)

At the last line of config.mk, there is DEFINES += -DBUILD_ID=$(shell cat $(DEPTH)/config/build_number) Which is a very poor use of $(shell) because it evaluates and launches a sub-process every time DEFINES is used in a makefile. It should instead use an intermediate immediate-evaluation var so that we only `cat` once.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Attached patch v1 patchSplinter Review
Attachment #181094 - Flags: review?(benjamin)
Attachment #181094 - Flags: review?(benjamin) → review+
Comment on attachment 181094 [details] [diff] [review] v1 patch trivial change, no risk.
Attachment #181094 - Flags: approval1.8b2?
Attachment #181094 - Flags: approval1.8b2? → approval1.8b2+
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: