290921 - Funky drop down box scroll bar behaviour

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Kai de Leeuw]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050418 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050418 Firefox/1.0+

When I open prefs > content > fonts & colors > advanced, all the drop down boxes
in this dialog with scrollbars behaves very strangely when I use them.

For instance, clicking in the "thumb" when it is at its upmost position and
trying to drag it down, I seem to have to travel quite a distance down, until I
am no longer with the mouse pointer of the thumb, to be able to move the thumb down.

Reproducible: Always

Steps to Reproduce:
1. Open prefs > content > fonts & colors > advanced
2. Use the scrollbars in drop downs
3. Notice the funky behaviour

Comment 1

[José Jeria]

This works fine in the 20050417 build, fresh regression

Steps to reproduce
1. go to tools/options/content/font & colors/advanced
2. Expand the sans-serif dropdown
3. Scroll it using the scrollbar thumb, the cursor position will not be on the
scrollbar

Comment 2

[Caleb]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050418
Firefox/1.0+

Confirmed.

Comment 3

[Tuukka Tolvanen (sp3000)]

linux gtk2 firefox trunk 2005-04-18-07Z: When dragging scrollbar thumb in a
single-select box dropdown list (example: Component dropdown on this bug
report), the thumb is offset downward approximately by the distance between top
edge of web page viewport and the select widget. The scroll position of the list
follows the thumb, not mouse pointer location.

Comment 4

[Martijn Wargers (dead)]

I remember the last time some similar regression occured, that was bug 254061.

Comment 5

[atzaus]

Confirmed. Happens on every single drop down.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050419
Firefox/1.0+

Comment 6

[tabmix.onemen]

Confirmed

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The problem is that in popups, GetClientX/Y actually returns coordinates
relative to top-left of the popup.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

sigh

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 181205 [details] [diff] [review]
fix

r+sr=bzbarsky, with vile imprecations hurled at certain XUL authors who shall
remain nameless...

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181205 [details] [diff] [review]
fix

fix scrolling event coordinate code to handle bizarre behaviour of DOM
.clientX/.clientY in popups

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181205 [details] [diff] [review]
fix

fix scrolling event coordinate code to handle bizarre behaviour of DOM
.clientX/.clientY in popups (regression)

Comment 12

[Boris Zbarsky [:bzbarsky]]

I just had a thought... is the bogosity with walking up from the document widget
an issue for popups inside subframes?  Could you test those, roc?

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: better fix

Using screen coordinates is quite clean and looks foolproof.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 181241 [details] [diff] [review]
better fix

Rename clientPosPx to ourPosPx (or posPx?), and r+sr=bzbarsky

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181241 [details] [diff] [review]
better fix

a more robust fix to the combobox dropdown scrollbar regression

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 181241 [details] [diff] [review]
better fix

a=asa

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on Windows XP Seamonkey trunk (Mozilla/5.0 (Windows; U; Windows
NT 5.1; en-US; rv:1.8b2) Gecko/20050421)