Closed
Bug 291014
Opened 19 years ago
Closed 19 years ago
GetProductBuildID doesn't handle ^M properly
Categories
(SeaMonkey :: Installer, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.0alpha
People
(Reporter: csthomas, Assigned: csthomas)
Details
Attachments
(1 file)
|
758 bytes,
patch
|
csthomas
:
review+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
My build ID is getting a ^M on the end of it, which causes my installer to crash due to the bogus version string |1.8.0.| instead of |1.8.0.something| which gets saved into config.ini.
|
Assignee | |
Comment 1•19 years ago
|
||
<CTho> http://ctho.ath.cx/tmp/deleteme2.diff - is that ok? <bsmedberg> r=me
Assignee: general → cst
Status: NEW → ASSIGNED
Attachment #181176 -
Flags: superreview?(dveditz)
Attachment #181176 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
Whiteboard: [cst: r?]
Target Milestone: --- → Seamonkey1.0alpha
|
|
Assignee | |
Updated•19 years ago
|
Attachment #181176 -
Flags: superreview?(dveditz) → approval1.8b2?
|
||
Comment 2•19 years ago
|
||
Comment on attachment 181176 [details] [diff] [review] patch a=asa
Attachment #181176 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [cst: r?] → checkin
|
|
Assignee | |
Comment 3•19 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: checkin
You need to log in
before you can comment on or make changes to this bug.
Description
•