291042 - [FIXr][MAS v1.8b2-0406+] A page with form, fill inputs and textarea, submit ... back, textarea data are missing

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Serge Gautherie (:sgautherie)]

Regressed between
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050329] (nightly) (W98SE)
and
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050418] (nightly) (W98SE)

Since this happens on a "private" access site
<http://www.battle-arenas.net/redac_missive.php>,
I'll try to find a public example, or attach a testcase...

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: Not fully reduced testcase

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050419] (nightly)
(W98SE)

This is the page, HTML and JS partly reduced.

Steps to reproduce:
1. Open the page
2. tape anything in the "Message" area
3. Submit
3b (page loads)
4. Back

5-R. In -0329, the typed text is remembered; in -0418 and -0419, the typed text
is missing.

Comment 2

[Serge Gautherie (:sgautherie)]

1 day timeframe:

Work fine
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050404] (nightly) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050405] (nightly) (W98SE)

Broken
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050406] (nightly) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050407] (nightly) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050410] (nightly) (W98SE)

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050420] (nightly) (W98SE)

I hoped that this could have been fixed by bug 289301 (which I believe I have
seen too) checkin, but no, it's still broken.

Comment 4

[[e-mail]]

I've just done a quick test case and that failed too.

Comment 5

[[e-mail]]

Odd, I can't reproduce it with my testcase now...

Comment 6

[[e-mail]]

OK, so here's a reduced testcase:
<table><form><tr><td><input><textarea>
Yup, that's enough to demonstrate the bug!
Remove the <input> and the bug does not occur.
Move the <form> before the <table> and the bug does not occur.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comments in the patch say it all... This is a regression from the BindToTree
landing.

Comment 8

[Asa Dotzler [:asa]]

sicking and peterv, we're running out of time for 1.8b2 and it would be really
good to nail this regression before we ship. Can you guys take a look at this ASAP? 

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

ugh, sorry, i didn't know this was blocking 1.8b2 since i'm not on cc. Looking
into it now...

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 181439 [details] [diff] [review]
Fix

It'd be good if you could rename 'tmp' now that it is a bit more longlived.
Something like:

  nsIContent* parent = content->GetParent();

  ....

  content = parent;
}

would IMHO be nicer.

r=me either way.


On an unrelated note. The way to check for anonymous content seems excessive.
Wouldn't a simple bindingparent comparison be enough? Different bug though.

Comment 11

[Boris Zbarsky [:bzbarsky]]

> Wouldn't a simple bindingparent comparison be enough? Different bug though.

In general no, because of the many different types of anon content we have... I
agree that we should file a bug on sorting this out; I want an IsAnonymous()
method on nsIContent, myself.  ;)

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 181439 [details] [diff] [review]
Fix

"asa:	blocking1.8b2+"

Comment 13

[chris hofmann]

Comment on attachment 181439 [details] [diff] [review]
Fix

a=chofmann

Comment 14

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 15

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050502] (nightly) (W98SE)

V.Fixed. (tested on comment 0 site)