291096 - Assertion not needed at widget/src/mac/nsWindow.cpp#2476

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[Ben Fowler]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050418 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050418 Firefox/1.0+

http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsWindow.cpp#2476 has 
an assertion followed by normal error handling. This assertion can be replaced
by a warning, and this is desirable per Bug 279923 "Assertions should be fatal".

See Bug 268157 comment 9 , and attachment (id=181121) . (This patch is NOT needed
for work on that bug).

Reproducible: Always




I suspect that this needs to be reviewed by brianryner or pinkerton per 
http://www.mozilla.org/owners.html#gfx-and-widget-mac

Comment 1

[Josh Aas]

I assume you're talking about the assertions in:

NS_IMETHODIMP nsWindow::ResetInputState()

When the file changes, lxr links don't work any more. Don't use those in bug
descriptions please.

Comment 2

[Ben Fowler]

Yes.

If you want the assertion there, then just close this report as INVALID (by
design).

Sorry about the mis-use of LXR. 

Comment 3

[Josh Aas]

Attachment: turn assertions into warnings

Just turn the assertions into warnings. I'm not comfortable removing them
myself. Pinkerton - should we remove them totally?

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 190039 [details] [diff] [review]
turn assertions into warnings

+	  NS_WARN_IF_FALSE(kb, "cannot get parent");
+	if (kb) {

fix the tab here, r=pink.

Comment 5

[Josh Aas]

I'll detab on checkin.

Comment 6

[Josh Aas]

landed