291188 - adjacent TDs overlap in RTL tables with parentheses

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Eyal Rozenberg]

Adjacent TDs overlap in an RTL table when the second TD begins with parentheses
See testcase or the Hebrew comments at the URL. This bug may or may not be
related to the BiDi regression in bug 290567.

Comment 1

[Eyal Rozenberg]

Attachment: testcase

Comment 2

[Eyal Rozenberg]

>This bug may or may not be related to the BiDi regression in bug 290567.

at least in the sense of having appeared at about the same time as that
regression and/or its fix.

Comment 3

[Simon Montagu :smontagu]

I've debugged this a bit and I think the regression is from bug 96423,
specifically the |if| at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsTextFrame.cpp&rev=1.502&mark=1690#1680

I'm not sure if it would be better to fix it by changing the condition to 
 if (mState & (TEXT_FIRST_LETTER | NS_FRAME_IS_BIDI))
or by removing it altogether. rbs, what do you think?

Here's a very minimized testcase:
data:text/html,<p dir="rtl">.a</p>

Comment 4

[Asa Dotzler [:asa]]

we'd consider approving a reviewed patch if it happens in time but we're not
blocking on this.

Comment 5

[rbs]

The patch in bug 291176 to implement the change of the condition in comment 3
has been checked in. Marking this fixed, then.

Comment 6

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).