291206 - Verbose Template Rule format does not support parsetype="Integer" for literal match conditions

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

I wish to conditionally construct content using a verbose template condition set
based on the value of a literal... if my literal is a string I can do:

<template>
  <conditions>
    ..
    <condition subject="?item"
               predicate="http://foo/bar#goat"
               object="goat_must_be_this_value"/>
  </conditions>
  ...
</template>

But if FB:goat is not a string, if it is a RDF Int literal, I can't do this:

<template>
  <conditions>
    ..
    <condition subject="?item"
               predicate="http://foo/bar#goat"
               object="42"
               parsetype="Integer"/>
  </conditions>
  ...
</template>

This works with the old style simple <rule>s though!

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: simple patch to make all roads lead to rome, that is, unify parsetype handling on new/old template condition types.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 181329 [details] [diff] [review]
simple patch to make all roads lead to rome, that is, unify parsetype handling on new/old template condition types. 

r=vladimir, looks sane to me;  Integer-with-a-capital-I looks too verbose, but
I guess that's the way the Romans have been doing it for a while...

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 181329 [details] [diff] [review]
simple patch to make all roads lead to rome, that is, unify parsetype handling on new/old template condition types. 

> nsresult
>+nsXULTemplateBuilder::ParseLiteral(const nsString& aParseType, 
>+                                   const nsString& aValue,
>+                                   nsIRDFNode** aResult)
>+{
...
>+    else {
>+        nsCOMPtr<nsIRDFLiteral> literal;
>+        gRDFService->GetLiteral(aValue.get(), getter_AddRefs(literal));
>+        rv = CallQueryInterface(literal, aResult);

If |literal| can ever come back null here, this will crash (CallQueryInterface
doesn't null check).  Does that happen if object is not set, or in some other
case?  If so, please do error checking here.

Looks ok otherwise.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 181329 [details] [diff] [review]
simple patch to make all roads lead to rome, that is, unify parsetype handling on new/old template condition types. 

a=me for 1.1a.	Using 1.8b2 for good measure cuz this is core code.

/be

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch for checkin

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

landed 1.8b2/1.1a