291234 - --with-toolkit=cairo-gtk2 build fails in netwerk/tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The tests in netwerk/tests link with TK_LIBS because apparently they (used to?)
depend on GTK (via chrome registry and themes). With cairo-gtk2 TK_LIBS contains
MOZ_CAIRO_LIBS which are built by gfx. But netwerk builds before gfx so the
tests fail to link.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

As far as I can tell, the netwerk tests still work with this patch.

Comment 2

[Darin Fisher]

Hrm... last year I needed to call gtk_init and friends prior to starting XPCOM
in order to make these tests work due to some crash in the widget code.  Please
don't break the network tests! ;-)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Like I said ... they seem to work, although some of them I don't know how to
tell if they succeeded or failed.

Comment 4

[Darin Fisher]

ok, ok ;-)  so long as "TestProtocols -verbose http://www.mozilla.org/" spits
out HTML at you, all is good.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, that works.

Comment 6

[Darin Fisher]

and, non-cairo gtk2 builds are happy too?  maybe widget code was fixed to not
crash anymore if gtk_init hasn't happened?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, non-Cairo gtk2 builds are still happy.

If I understand correctly, bsmedberg removed the dependency on widget a while ago.

Comment 8

[Darin Fisher]

Comment on attachment 181369 [details] [diff] [review]
fix

r+sr=darin

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181369 [details] [diff] [review]
fix

r+sr=darin on IRC

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181369 [details] [diff] [review]
fix

This patch gets Cairo-gtk2 closer to working and only affects netwerk tests
(and I checked that they still work).

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 181369 [details] [diff] [review]
fix

a=asa

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in