291390 - Failure opening bookmarks menuitem

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Pardal Freudenthal (:ShareBird)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050410 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050420 Firefox/1.0+

If you have a long list of bookmarks (around 80) and a folder at the end of this
list, its contents will not be accessible through bookmarks menu at main menu,
a menuitem will not popup if you scroll down until this folder. I guess this
menuitem will popup in a wrong position like the testcase demonstrate.

This issue started with Build 20050405. Build 20050404 works as expected.

Reproducible: Always

Steps to Reproduce:
1.Use "Bookmarks -> Manage Bookmarks..." to import the attached bookmark file
2.Go to Bookmarks menu at main menu
3.Open the "Test Case" folder
4.Point the mouse over the "Folder 00". A menuitem will normally popup.
5.Scroll down to "Folder 01", "Folder 02", "Folder 03" and "Folder 04". "Folder
04 will not popup its contents...
6.Scroll up to "Folder 03", "Folder 02" and "Folder 01". 
Actual Results:  
Abnormal behaviour from menuitem popup.

Expected Results:  
Mouse pointing folders at bookmarks menu should popup menuitem with its contents
normally.

Comment 1

[Pardal Freudenthal (:ShareBird)]

Attachment: A long list of bookmarks with folders

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: testcase

This testcase shows that this is not specific to bookmarks. I suspect the
product and component should be updated accordingly but I am unsure exactly
what they should be.

Comment 3

[tabmix.onemen]

Attachment: another testcase

check this test

Comment 4

[tabmix.onemen]

Comment on attachment 181507 [details]
another testcase

maybe this bug related to the showPopup position bug, look at User Contributed
Notes in xulplanet Popup about this issue

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Bonsai for that range shows bug 256505 as a possible cause.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Bug 291083 is 1.9-era work, so it's not really a blocker for fixing this regression.

I don't know what the hours on the builds in comment 0 were (you really want to
include those, not just the date), but build 2005-04-05-06 works fine.  Build
2005-04-06-06 is broken.

Tried backing out bug 256505, and  that fixed the issue here...

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

nsMenuPopupFrame does all this work to calculate view offsets that I think is
entirely unnecessary. I don't know why it wants to ignore the offsets of some
scrolled views. If I replace this with the obvious simple code, things seem to
work (nested menus, menus near screen boundaries, etc) and in particular this
bug is fixed. In particular, context menus in scrolled documents work. Anything
else I might have forgotten to test?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 181818 [details] [diff] [review]
fix

r+sr=bzbarsky, but one thing you should test is a XUL menu inside a scrolled
document.  That should exercise that second chunk of code (where we're aligning
to a frame); context menus do not exercise it.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, that works.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181818 [details] [diff] [review]
fix

fixes menu regression and simplifies the menu code a lot.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 181818 [details] [diff] [review]
fix

a=asa

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 13

[Andrew Schultz]

*** Bug 293213 has been marked as a duplicate of this bug. ***