291436 - r:\mozilla\layout\generic\nsBlockFrame.h(628) : warning C4099: 'nsBlockFrame::nsAutoOOFFrameList' : type name first seen using 'struct' now seen using 'class'

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[timeless]

r:\mozilla\layout\generic\nsBlockFrame.h(628) : warning C4099:
'nsBlockFrame::nsAutoOOFFrameList' : type name first seen using 'struct' now
seen using 'class'
        r:\mozilla\layout\generic\nsBlockFrame.h(613) : see declaration of
'nsBlockFrame::nsAutoOOFFrameList'

Comment 1

[timeless]

Attachment: match decl

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 181531 [details] [diff] [review]
match decl

a=shaver

Comment 3

[timeless]

Comment on attachment 181531 [details] [diff] [review]
match decl

mozilla/layout/generic/nsBlockFrame.h	3.205

Comment 4

[pete]

The C++ standard explicitly says this code is correct (7.1.5.3/3), but believe
me, you want to change the build options to treat this warning as an error just
to get around Microsoft's stupidity. Their compiler mangles structs and classes
differently and this can generate a very cryptic link error under certain
conditions (you get no line numbers and when you demangle the mangled function,
one of the parameters is a struct instead of a class (or vice versa) and it's
very, very hard to notice something that subtle). When it happened to me, it
took nearly 4 hours to figure out what was wrong and my code base is nowhere
near the size of mozilla's.