Closed
Bug 291504
Opened 19 years ago
Closed 19 years ago
sync-output and focus-input should not have CMD_CONSOLE set, raw can do without CMD_NEED_SRV
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gijs, Assigned: Gijs)
Details
(Whiteboard: [cz-0.9.69])
Attachments
(1 file)
3.78 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
sync-output is not a command your general user should / would want to use. We should not bother the user with it in the /commands reply. At the same time, using 'focus-input' from the input box is absolutely non-useful for anyone, so it shouldn't have CMD_CONSOLE either (again, now it just clutters up the /commands reply). 'raw' is an alias for 'quote', which has CMD_NEED_SRV set by itself. Setting it for raw as well is redundant, since we don't pay attention to flags set on aliases (except CMD_CONSOLE).
Assignee | ||
Comment 1•19 years ago
|
||
Fixes the commands named above.
Attachment #181564 -
Flags: review?(silver)
Comment 2•19 years ago
|
||
Comment on attachment 181564 [details] [diff] [review] Patch r=silver
Attachment #181564 -
Flags: review?(silver) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #181564 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #181564 -
Flags: approval1.8b3? → approval1.8b3+
Comment 3•19 years ago
|
||
Checked in -> FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Whiteboard: [cz-0.9.68.6]
Updated•18 years ago
|
Whiteboard: [cz-0.9.68.6] → [cz-0.9.69]
You need to log in
before you can comment on or make changes to this bug.
Description
•