291537 - unable to use drag and drop to move local folders around

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[(not reading, please use [e-mail] instead)]

unable to use drag and drop to move local folders around

I am only able to click on a folder in the folder pane.  I can't see to click
drag and hold at all.

I'm using version 1.0+ (20050422) on windows xp.

I think this is a recent regression?

Comment 1

[Scott MacGregor]

i think so too

Comment 2

[Scott MacGregor]

The event for the drag and drop has bad coordinates which cause us to fail to
get the row:

http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/messengerdnd.js#355

var row = folderTree.treeBoxObject.getRowAt(event.clientX, event.clientY);

row is always -1 in this scenario.

Comment 3

[(not reading, please use [e-mail] instead)]

did bz change the coord stuff recently?

Comment 4

[Scott MacGregor]

event.clientX and event.clientY look like negative values to me using trunk
builds. If I run a 1.0 build and try to drag the same folder, I get positive
coordinates fo clientX and clientY. 

Comment 5

[Scott MacGregor]

Bug #289792 could be the culprit.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So when, exactly, did this break?  For that matter, is the problem reproducible
in Seamonkey mailnews?  If so, and if someone tells me clearly how to reproduce
it, I could probably figure out the regression period.

The changes in bug 289792 shouldn't have affected the client coords of any mouse
events.

The changes in bug 255378, on the other hand, could have.

Comment 7

[Scott MacGregor]

Boris, to reproduce, just open up your local folders, click on one and try to
drag it onto another local folder.

nsITreeBoxObject.getRowAt always returns an invalid row (-1) based on these new
event coordinate values we are now getting.

Comment 8

[Boris Zbarsky [:bzbarsky]]

> Boris, to reproduce, just open up your local folders, click on one and try to
> drag it onto another local folder.

That does absolutely nothing in Seamonkey mailnews and hasn't in a good long
while, if it ever did (tested a build from March 2005, January 2005, and then
from April 2004)...  I tried dragging Sent to Templates, if that matters.

Comment 9

[(not reading, please use [e-mail] instead)]

> That does absolutely nothing in Seamonkey mailnews and hasn't in a good long
> while, if it ever did (tested a build from March 2005, January 2005, and then
> from April 2004)...  I tried dragging Sent to Templates, if that matters.

it will work in seamonkey, assuming that the folder you are trying to move is
"movable".

"Sent" is a special folder, so you probably got the "deny" cursor.

try creating a new local folder first (like "aaa") and try dragging and dropping
that to the trash folder.

Comment 10

[Boris Zbarsky [:bzbarsky]]

> "Sent" is a special folder, so you probably got the "deny" cursor.

I actually got no feedback whatsoever... I'll try creating a new local folder, I
guess (this is where steps to reproduce come in!).

Comment 11

[(not reading, please use [e-mail] instead)]

> I actually got no feedback whatsoever... I'll try creating a new local folder, I
> guess (this is where steps to reproduce come in!).

That's part of the bug.  Try again with your build from March 2005, January
2005, and April 2004 to see the difference.

Comment 12

[Boris Zbarsky [:bzbarsky]]

OK.  So now I can reproduce, and I see the following behavior:

1)  2005-04-14-06 build works fine
2)  2005-04-15-06 through 2005-04-17-06 the drop position is offset (bug 290494).
3)  2005-04-18-06 and later I can't even start dragging the folder (never get a
    drag cursor)

I assume item #3 is what this bug is about?

If so, it seems to be caused by the fix for bug 288406 (tested via local backout).

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The early call to StopDragGesture was wiping out the mGestureDownPoint. We can
simply not wipe it out. All that matters in StopDragGesture is that we set the
target content to null so IsTrackingDragGesture subsequently returns PR_FALSE.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 181934 [details] [diff] [review]
fix

simple fix for a folder drag-drop regression.

Comment 15

[Scott MacGregor]

roc, thanks for the quick turn around on the fix.

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 181934 [details] [diff] [review]
fix

a=asa

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in