291736 - nsLocalFileOS2.cpp won't compile

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rich Walsh]

The parent of this file's nsDirEnumerator class was changed from
nsISimpleEnumerator to nsIDirectoryEnumerator.  Now, attempts to QI to
SimpleEnum fail.  This patch removes the QI and uses the object pointer to
invoke the enum methods.

Comment 1

[Rich Walsh]

Attachment: fix for nsLocalFileOS2.cpp

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

isn't this the wrong fix? QI to nsISimpleEnumerator should still work, if it
doesn't, that should be fixed...

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Use the Windows code

Isn't the correct thing to do here just to take the Windows code? There is
nothing platform specific about it.

I have NOT built this code - I'm at home on my Windows machine.

Comment 4

[Peter Weilbacher]

Do I see correctly that in the current code the allocation to dirEnum is never
freed?

Comment 5

[Mike Kaply [:mkaply]]

Attachment: A compiling fix

This is what I checked in.