291753 - {application}-bin cannot be linked with libxremote_client_s.a if system NSPR is used

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

If I build --with-system-nspr linking fails at mozilla-bin with following error:
c++ -o mozilla-bin -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall
-Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ct
or-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -O2 -march=i586
-mcpu=i686 -fmessage-length=0 -Wall -fno-strict-aliasing -fshort-wchar 
-pthread -pipe  -DNDEBUG -DTRIMMED -ffunction-sections -O2 -march=i586
-mcpu=i686 -fmessage-length=0 -Wall -fno-strict-aliasing -DWIDGET_DLL=\"libwidg
et_gtk2.so\" -DGFXWIN_DLL=\"libgfx_gtk2.so\" -DXTHREADS -D_REENTRANT
-DXUSE_MTSAFE_API -I/opt/gnome/include/gtk-2.0 -I/opt/gnome/lib/gtk-2.0/include -
I/usr/X11R6/include -I/opt/gnome/include/atk-1.0 -I/opt/gnome/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/
freetype2/config -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include
   nsAppRunner.o showOSAlert.o nsSigHandlers.o nsStackFrameUnix.o nsN
ativeAppSupportGtk.o nsNativeAppSupportBase.o      -Wl,-T,ldscript
-L../../dist/bin -L../../dist/lib    -L../../dist/bin -lxpcom -lxpcom_core  -L../..
/dist/bin -lmozjs -L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl 
-L/opt/gnome/lib   -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpa
ngoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
  -L/usr/X11R6/lib -lX11  ../../widget/src/xremoteclient/libxremote_cl
ient_s.a -ldl -lm      
../../widget/src/xremoteclient/libxremote_client_s.a(XRemoteClient.o)(.text._ZN13XRemoteClient7GetLockEmPi+0x335):
In function `XRemoteClient::GetLock
(unsigned long, int*)':
XRemoteClient.cpp: undefined reference to `PR_GetSystemInfo'
collect2: ld returned 1 exit status

The ordering of the build options is insufficient. If I add "-lnspr" at the end
of the line it works.

Comment 1

[Benjamin Smedberg]

Patches welcome! You basically need to move
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/bootstrap/Makefile.in&rev=1.278&mark=351-354#350
earlier in the Makefile.

Comment 2

[cls]

Attachment: Fix link order

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

would somebody check this in please? (if not already happened)

Comment 4

[Robert Kaiser]

Checking in xpfe/bootstrap/Makefile.in;
/cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v  <--  Makefile.in
new revision: 1.280; previous revision: 1.279
done