Closed
Bug 291868
Opened 19 years ago
Closed 19 years ago
Disable the variable redeclaration strict warning
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: Gavin, Assigned: brendan)
References
Details
(Keywords: js1.5)
Attachments
(1 file)
1.43 KB,
patch
|
shaver
:
review+
brendan
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•19 years ago
|
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.8b2+
Assignee | ||
Comment 1•19 years ago
|
||
Another easy patch to get in. Ben will love it. /be
Attachment #182639 -
Flags: review?(shaver)
Attachment #182639 -
Flags: approval1.8b2+
Comment on attachment 182639 [details] [diff] [review] fix r=shaver. (I wanted to make a "silence of the lambdas" joke here, but it just wouldn't come.)
Attachment #182639 -
Flags: review?(shaver) → review+
Updated•19 years ago
|
Flags: testcase-
Assignee | ||
Comment 3•19 years ago
|
||
Checked in, thanks. /be
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 4•19 years ago
|
||
Did you mean to cover code snippets like this one? if (total == 0) var statusText = gAddressBookBundle.getString("noMatchFound"); else { if (total == 1) var statusText = gAddressBookBundle.getString("matchFound"); else var statusText = gAddressBookBundle.getFormattedString("matchesFound", [total]); }
Assignee | ||
Comment 5•19 years ago
|
||
I meant to do what I did: remove the strict warning for a var redeclaration of an identifier declared using var previously in the same compilation unit. /be
You need to log in
before you can comment on or make changes to this bug.
Description
•