292118 - Make transformiix compile for windows ce

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

Attachment: ERROR is defined on Windows CE

Comment 2

[timeless]

1. ERROR isn't actually *used* by ExprLexer.(h|cpp).
2. eEnum or eENUM is much nicer.

could we possibly change to the style described by 2?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

ERROR does indeed look unused (if you remove it, please update the numbers in
the enum) and I'd be all for chaning constant-style.

Comment 4

[Axel Hecht]

I vote for 

-        ERROR = 0,
-        NULL_TOKEN,
+        NULL_TOKEN = 1,

Just to throw in another scheme. Peter?

Comment 5

[Axel Hecht]

Comment on attachment 181983 [details] [diff] [review]
ERROR is defined on Windows CE

I guess we pretty much agree that this is not "it".

Comment 6

[Peter Van der Beken [:peterv]]

(In reply to comment #4)
> I vote for 
> 
> -        ERROR = 0,
> -        NULL_TOKEN,
> +        NULL_TOKEN = 1,

I'm fine with this, it's the least invasive.

Comment 7

[Doug Turner (:dougt)]

Attachment: patch as suggested.

Comment 8

[Axel Hecht]

Comment on attachment 182079 [details] [diff] [review]
patch as suggested.

r=me, requesting sr from peterv

Comment 9

[Doug Turner (:dougt)]

Checking in extensions/transformiix/source/xpath/ExprLexer.h;
/cvsroot/mozilla/extensions/transformiix/source/xpath/ExprLexer.h,v  <-- 
ExprLexer.h
new revision: 1.20; previous revision: 1.19
done

Asa gave permission to a 291229 which included this patch.
Thanks.