292126 - Use "legal" version numbers

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Peter van der Woude [:Peter6]]

The Chatzilla extension currently uses letters in it's version which will not
work in Firefox.

read http://www.mozilla.org/projects/firefox/extensions/update.html
for the rules and options.

Comment 1

[James Ross]

My personal opinion is "no", and to not allow Firefox users use of the middle
development versions.

And please don't give me any bullshit on comparing versions.

Comment 2

[James Ross]

Just to make things clear, my second remark is not aimed at the reporter or
anyone specifically, just mearly warning people what arguments will NOT work
within this bug. :)

Comment 3

[Wolf [:wolf]]

So, my personal opinion is that CZ's versioning should've been legal in the
Firefox EM sense of things, but. heh.

Unfortunately, this *breaks* CZ from being able to install (or be upgraded from
the update serivce, which isn't a new thing, since VersionCheck already strictly
parsed the version strings.), in Firefox nightlies, and I disagree that I should
have to modify the install.rdf just to get a CZ dev version, (which are often
passed around as the newest version) to install.

The function that does the parsing appears to be this:
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1149
(from Bug 291582)

Comment 4

[James Ross]

I know what it 'breaks'. Some points:

  - lettered versions will simply be unavailable from UMO, rather than changing
(note that UMO is quite happy for people to submit such versioned items, so it
is not strict enough).
  - trunk, and thus nightly builds, will always be compatible (sometimes using
the "+", which had damn well still work!).
  - generally speaking, we're moving away from non-checked-in versions, meaning
there will be less lettered versions anyway.

Plus, Firefox sucks. *ahem* ;-)

Comment 5

[Wolf [:wolf]]

Sounds reasonable. :-)

There's a bug somewhere for making UMO's version checking more strict. It didn't
happen originally because I didn't want UMO to be more strict than the client
for exactly this kind of reason, bah.

Comment 6

[:Gijs (he/him)]

Err, so what exactly is the problem here? 
* No version before 0.9.68 will work on Fx trunk *anyway* (see bug 287729). 
* For now, people can use the nightlies (which will shortly be on par with
0.9.68a - and better). 

So, since it's no use re-versioning anything before 0.9.68, and nightlies are
already nearly equivalent to 0.9.68a, there is no real use re-versioning that
either (it'd just cause confusion among users). I'd vote to INVALIDate this bug
- ChatZilla devs are well aware of this new limitation of the install system,
and I'm sure they will take care of it in new versions - which seems to be all
that's necessary, which means this bug is rather useless.

Comment 7

[Wolf [:wolf]]

The newest version is now 0.9.68.2, which is legal, I'd say this bug is fixed. :-)

There's no reason to go back and fix old releases for Firefox. Use it as a
reason to force Firefox 1.1 Chatzilla users to upgrade.

Comment 8

[:Gijs (he/him)]

(In reply to comment #7)
> The newest version is now 0.9.68.2, which is legal, I'd say this bug is fixed. :-)

Agreed.