292263 - ATOK's Moji Palette that is like software keyboard doesn't work

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

ATOK's Moji Palette that is like software keyboard doesn't work.
This is same as bug 52416.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 182093 [details] [diff] [review]
Patch rv1.0

I'm not qualified to review this....  Someone who knows something about IME and
key events would have to look at this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Comment on attachment 182093 [details] [diff] [review]
Patch rv1.0

timeless:
Can you review it?

Comment 4

[Masaki Katakai]

I had made the original changes at bug 52416 for UNIX IME.
No problem in this patch, even for Windows, I think.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Thank you, Katakai-san.

Comment 6

[[e-mail]]

Comment on attachment 182093 [details] [diff] [review]
Patch rv1.0

Looks OK, although I don't think that's correct style for nested #ifdefs -
don't indent them, but do put comments to explain which #endif matches which
#if. In fact I wonder if it's still worth using #if any more.

Note: -u10 would have worked better for this diff. Don't just blindly put -u8
in your .cvsrc :-P

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.1

The patch's risk is low.
But this bug is major.

Comment 8

[chris hofmann]

Comment on attachment 182181 [details] [diff] [review]
Patch rv1.1

a=chofmann

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

checked-in.