Closed
Bug 292263
Opened 19 years ago
Closed 19 years ago
ATOK's Moji Palette that is like software keyboard doesn't work
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: masayuki, Assigned: masayuki)
Details
(Keywords: inputmethod, intl)
Attachments
(1 file, 1 obsolete file)
3.09 KB,
patch
|
masayuki
:
review+
masayuki
:
superreview+
chofmann
:
approval1.8b2+
|
Details | Diff | Splinter Review |
ATOK's Moji Palette that is like software keyboard doesn't work. This is same as bug 52416.
Assignee | ||
Updated•19 years ago
|
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #182093 -
Flags: superreview?(bzbarsky)
Attachment #182093 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Comment 2•19 years ago
|
||
Comment on attachment 182093 [details] [diff] [review] Patch rv1.0 I'm not qualified to review this.... Someone who knows something about IME and key events would have to look at this.
Attachment #182093 -
Flags: superreview?(bzbarsky)
Attachment #182093 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 182093 [details] [diff] [review] Patch rv1.0 timeless: Can you review it?
Attachment #182093 -
Flags: review?(timeless)
Attachment #182093 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #182093 -
Flags: review?(timeless)
Attachment #182093 -
Flags: review+
Comment 4•19 years ago
|
||
I had made the original changes at bug 52416 for UNIX IME. No problem in this patch, even for Windows, I think.
Assignee | ||
Comment 5•19 years ago
|
||
Thank you, Katakai-san.
Comment 6•19 years ago
|
||
Comment on attachment 182093 [details] [diff] [review] Patch rv1.0 Looks OK, although I don't think that's correct style for nested #ifdefs - don't indent them, but do put comments to explain which #endif matches which #if. In fact I wonder if it's still worth using #if any more. Note: -u10 would have worked better for this diff. Don't just blindly put -u8 in your .cvsrc :-P
Attachment #182093 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Assignee | ||
Comment 7•19 years ago
|
||
The patch's risk is low. But this bug is major.
Attachment #182181 -
Flags: superreview+
Attachment #182181 -
Flags: review+
Attachment #182181 -
Flags: approval1.8b2?
Assignee | ||
Updated•19 years ago
|
Attachment #182093 -
Attachment is obsolete: true
Comment 8•19 years ago
|
||
Comment on attachment 182181 [details] [diff] [review] Patch rv1.1 a=chofmann
Attachment #182181 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 9•19 years ago
|
||
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Keywords: inputmethod
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•