292355 - Plugins send document's base URI as referrer, instead of document's URI

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

5932         httpChannel->SetReferrer(doc->GetBaseURI());

shouldn't that be doc->GetDocumentURI()?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, that should be GetDocumentURI() (see what links send, and images, and so
forth).  Want to post a patch, biesi?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

only the second hunk of the patch is needed to fix this bug, the rest is
removing some unnecessary casts and indentation fixing.

I'd attach a testcase, but hard to do without inspecting server logs or writing
plugin content

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 182225 [details] [diff] [review]
patch

r=jst

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 182225 [details] [diff] [review]
patch

low risk patch to send the correct referrer for plugins

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 182225 [details] [diff] [review]
patch

a=asa

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <-- 
nsPluginHostImpl.cpp
new revision: 1.523; previous revision: 1.522
done