292373 - Plugin Installation Fails / about:plugins returns "No plug-ins are installed"

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050429
Firefox/1.0+

1. Create a new profile and start firefox with it.
2. Go to http://www.macromedia.com/shockwave/welcome/
3. Note that additional plugins are required to display all the media on this page.
4. Choose to install Flash. (Bottom plugin placeholder)
5. Next > I Agree > Next. Download of plugin starts. Progress bar rises.
6. Download completes. Click Finish.
7. Page reloads itself. Note that flash is not installed, and the animation
playing that should show that Flash has installed is still the plugin
placeholder inviting you to install Flash.

Plugin Installation works with the Official 20050429 nightly build, but fails
with a beast build after this, so bug 292114 is not to blame (lesson learnt :))

Comment 1

[Mike Pesce (:By-Tor)]

In addition to the problems with Flash not being installed, none of my existing
plugins are recongnized either.  about:plugins shows, "No plug-ins are installed."

Comment 2

[Steve England [:stevee]]

Checkins between 292114 and when I pulled my beast build:
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1114779660

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm...  There's really nothing in that range that should affect plugins....  If
you're doing self-builds, can you narrow down when this broke?  If not, I can try...

Comment 4

[Steve England [:stevee]]

Sorry bz, when "I pulled my beast build" i meant "I downloaded my beast build."
I don't build firefox myself, so I can't do anything wrt helping narrow the
regression time down further.

Comment 5

[Dave Townsend [:mossop]]

I get this too on Windows XP. My checkout was Apr 29 14:56:55 GMT (between dougt
and bzbarsky's checkins in the list steve posted).

Dave

Comment 6

[Steve England [:stevee]]

From IRC
Mossop said: The checkout for my build was 14:56 GMT and it has the problem
Mossop said: You can narrow that down to
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1114779660&maxdate=1114783140
Hope that helps.

Comment 7

[Steve England [:stevee]]

From
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1114779660&maxdate=1114783140
Two changes are WinCE (not part of normal builds)
One is an Automated update from host egg
One is a change for cairo/SVG
And the last one is a change in mailnews.

So could Tinderbox be lieing about (1) the times things landed (2) what landed ?

Comment 8

[Peter van der Woude [:Peter6]]

additional.
Even if plugins were installed before (a bunch of dll's in /plugins/) , they are
simply not registered by FF and about:plugins is empty

Comment 9

[Dave Townsend [:mossop]]

Ok I've done a build in the middle of those checkouts and it flash worked just
fine. So the problem is one of dougt's checkings:

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1114781520&maxdate=1114783140

Odd considering they are WinCE bits.

Dave

Comment 10

[TimoT]

mozilla/modules/plugin/base/src/Makefile.in

-ifeq ($(OS_ARCH),WINNT)
+ifneq (,$(filter WINNT WINCE,$(MOZ_WIDGET_TOOLKIT)))

should that n (ifeq/ifneq) be there?

Comment 11

[Doug Turner (:dougt)]

sorry, my fault.


In modules/plugin/base/src/Makefile.in, 

ifneq (,$(filter WINNT WINCE,$(MOZ_WIDGET_TOOLKIT)))

should read:

ifneq (,$(filter WINNT WINCE,$(OS_ARCH)))

That is to say:

MOZ_WIDGET_TOOLKIT should be OS_ARCH, right?

Comment 12

[Dave Townsend [:mossop]]

Did a build with that change in and it fixes it

Comment 13

[Mike Shaver (:shaver emeritus)]

Checked this patch in, waiting for test report from #developers on the next
beast build.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

fwiw I can verify that windows uses nsPluginsDirUnix.cpp without that patch

Comment 15

[Mike Shaver (:shaver emeritus)]

Fixed on trunk.

Comment 16

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050430
Firefox/1.0+ 1026PDT build

verified

Comment 17

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050430
Firefox/1.0+

- Existing extensions are now recognised
- about:plugins is populated as expected
- installation of flash from http://www.macromedia.com/shockwave/welcome/ now works.

Resolved FIXED by bug 291229

Comment 18

[Doug Turner (:dougt)]

shaver, thanks for taking the lead on fixing this.  I wasn't available last
night or today.  I owe you a pint!

Comment 19

[Hermann Schwab]

could this bug be responsible for missing talkback in the current nightly?

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050501

BuildID 2005050105 is missing the talkback files: 
fullsoft.dll, master.ini, qfaservices.dll, qfaservices.xpt, talkback.cnt,
talkback.exe, talkback.hlp, talkback-l10n.ini

http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-05-01-06-trunk/mozilla-i586-pc-msvc.zip
filesize 10.945 KB or 10.6 MB windows explorer vs. properties,

The preceding nightly had talkback, and this bug seems to be the only one which
checked in a .in file.