292908 - r:/mozilla\intl\uconv\src\nsTextToSubURI.cpp(231) : warning C4309: 'argument' : truncation of constant value

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

r:/mozilla\intl\uconv\src\nsTextToSubURI.cpp(231) : warning C4309: 'argument' :
truncation of constant value

238 ** Bit masking macros.  XXX n must be <= 31 to be portable
240 #define PR_BIT(n)       ((PRUint32)1 << (n))

123   esc_SkipControl    = PR_BIT(15)  /* skips C0 and DEL from unescaping */

140 NS_COM PRBool NS_EscapeURL(const char *str,
141                            PRInt32 len,
142                            PRInt16 flags,
143                            nsACString &result);
156 NS_COM PRBool NS_UnescapeURL(const char *str,
157                              PRInt32 len,
158                              PRInt16 flags,
159                              nsACString &result);
162 inline PRInt32 NS_UnescapeURL(char *str) { return nsUnescapeCount(str); }
168 NS_EscapeURL(const nsASingleFragmentCString &part, PRInt16 partType,
nsACString &result) {
175 NS_UnescapeURL(const nsASingleFragmentCString &str, PRInt16 flags,
nsACString &result) {

230   NS_UnescapeURL(PromiseFlatCString(aURIFragment), 
231                  esc_SkipControl | esc_AlwaysCopy, unescapedSpec);

the problem is that you have 1 sign bit and 15 int bits, and we're trying to
pass a value in the 16th data bit (which doesn't exist). darin says it's ok to
switch to pruint32, so that's what the patch will do.

Comment 1

[timeless]

Attachment: fix flags to hold at least 16 flags

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 182622 [details] [diff] [review]
fix flags to hold at least 16 flags

a=shaver

Comment 3

[timeless]

Comment on attachment 182622 [details] [diff] [review]
fix flags to hold at least 16 flags

mozilla/xpcom/io/nsEscape.h	1.25
mozilla/xpcom/io/nsEscape.cpp	1.34