292923 - crash forward/backward - Trunk [@ nsDocShell::FireRestoreEvents ]

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+

testing for bug 274784

settings:
set browser.sessionhistory.max_viewers 10
set browser.history_expire_days 0

repro:
1.open FF
2.open forums and go back and forwards visiting threads
3. crash

talkback TB5584080Q

Comment 1

[Peter van der Woude [:Peter6]]

->TB5584352Y

to be precise
open http://forums.mozillazine.org/viewforum.php?f=23
pick a thread , go forward an back (if needed a few times)

Comment 2

[Peter van der Woude [:Peter6]]

confirmed crash by others (via irc)

settings
set browser.sessionhistory.max_viewers 10
set browser.history_expire_days 9

still results in crashes

set browser.sessionhistory.max_viewers 0 (off)
fixes it

Comment 3

[Steve England [:stevee]]

*** Bug 292926 has been marked as a duplicate of this bug. ***

Comment 4

[Brendan Eich [:brendan]]

You want bfcache (blazingly fast back, whatever) bugs in Core / Session: History
and you want bryner cc'd at least.

/be

Comment 5

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050504
Firefox/1.0+

browser.sessionhistory.max_viewers = 50
browser.history_expire_days  = 365

I think this might be adblock related.

1. Enable adblock 
2. Go to slashdot.org
3. Pick an article
4. Go back
-> crash

Talkback looks the same as this
ID's:
TB5586455X
TB5586413W
TB5586150M
TB5585973E
TB5585395W
TB5584429M
(sorry I got trigger happy, won't submit any more TB for this issue, crashes
occured on different sites)

Repeat above with adblock disabled -> no crash

Comment 6

[Fred Collier]

(In reply to comment #1)
> ->TB5584352Y
> 
> to be precise
> open http://forums.mozillazine.org/viewforum.php?f=23
> pick a thread , go forward an back (if needed a few times)

WFM (back and forward 22 times)
set browser.sessionhistory.max_viewers 10
set browser.history_expire_days 1

Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b2) Gecko/20050505 Firefox/1.0+Beast

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050505
Firefox/1.0+

after some more testing:
1. I don't crash with a newly created profile (from scratch)
2. I don't crash with old profile, and extensions uninstalled
3. I DO CRASH with old profile, but extensions disabled

Comment 8

[Brian Ryner (not reading)]

Attachment: patch

Don't crash if there has never been a content viewer created (the about:blank
viewer, which I thought was always present, turns out to be created lazily). 
Instead of bailing, I have it potentially create the content viewer here, just
in case someone is listening for the DOMPageRestore event from this frame.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 182738 [details] [diff] [review]
patch

So this is basically a frame in which we never did a load, right?  If so, looks
reasonable.

Comment 10

[Brian Ryner (not reading)]

Right, in the adblock case it's a frame where the load was cancelled by
nsIContentPolicy.

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 182738 [details] [diff] [review]
patch

requesting 1.1a approval

Comment 12

[Peter van der Woude [:Peter6]]

*** Bug 293074 has been marked as a duplicate of this bug. ***

Comment 13

[Brendan Eich [:brendan]]

Comment on attachment 182738 [details] [diff] [review]
patch

a=me.

/be

Comment 14

[Brian Ryner (not reading)]

checked in

Comment 15

[Jay Patel [:jay]]

v.fixed per Talkback data, no crashes since 5/6