292960 - Possible to submit forms in cached presentations

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See testcase in URL field.

Comment 1

[Hixie (not reading bugmail)]

this crashes for me (linux).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm... I can't reproduce the crash, and it should be sorta-fixed for reasons
similar to bug 292961 (we'll still build the form submission, but not send it;
not sure where we drop the data).

Do you have a talkback incident ID, Ian?

Comment 3

[Hixie (not reading bugmail)]

TB5604335Z and TB5604301G.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah.  You have password manager enabled... care to file that as a separate bug
blocking bug 274784?  And probably blocked by this bug?  We shouldn't even be
getting into the password manager code.

Comment 5

[Brian Ryner (not reading)]

When I attempt to reproduce the problem using the testcase, I get (in the
console of a debug build):

WARNING: NS_ENSURE_TRUE(handler) failed, file c:/builds/mozilla/bfcache/mozilla/
content/html/content/src/nsFormSubmission.cpp, line 1223
JavaScript error: , line 0: uncaught exception: [Exception... "Component returne
d failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMHTMLFormElement.submit]"  n
sresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: https://bugzill
a.mozilla.org/attachment.cgi?id=181895 :: go :: line 9"  data: no]


It may be that something else can happen if the form we attempt to submit
contains a password field.  I'll do some more testing.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I filed the crash as bug 293176.

Note that we shouldn't be trying to notify form submit observers of a submit we
don't plan to do....

Comment 7

[Brian Ryner (not reading)]

Ok, since the password manager is created lazily, you have to have gone to a
page with a password field first.  Then I can reproduce the crash with the testcase.

Comment 8

[Brian Ryner (not reading)]

Attachment: don't notify form submit observers if there is no link handler

This also adds a bit of bulletproofing in nsPasswordManager.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 182817 [details] [diff] [review]
don't notify form submit observers if there is no link handler

r+sr=bzbarsky.	If the password manager change is relevant to the other one
too, could you make it there as well, please?

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 182817 [details] [diff] [review]
don't notify form submit observers if there is no link handler

a=[e-mail] for 1.8b2.

/be

Comment 11

[Brian Ryner (not reading)]

checked in, with appropriate bulletproofing in
extensions/wallet/src/nsWalletService as well.