293114 - function InitMessageLabel performs very poorly for large selections

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

i got a slow script dialog trying to get a context menu for select all in a big
newsgroup :)

Comment 1

[Daniel Brooks [:db48x]]

Attachment: 293114-1.diff

it could also skip the loop if the first item is labled with no label (or the
default label or whatever it's called.) I'd have to look and see what sort of
value checkedLabel gets in that case, and hardcode a test for it.

Comment 2

[[e-mail]]

Maybe we should do the same as what we do for deleted/junk/marked/flagged
messages i.e. just display the state of the first selected message.

Comment 3

[Daniel Brooks [:db48x]]

yea, could move the check down to the second if, that would do it

Comment 4

[Daniel Brooks [:db48x]]

Attachment: 293114-2.diff

or, as you say, it can simply take the value of the first message in the
selection

Comment 5

[[e-mail]]

Comment on attachment 182763 [details] [diff] [review]
293114-2.diff

In which case it would be more efficient to use hdrForFirstSelectedMessage as
per the SelectedMessagesAreXXX functions.

Comment 6

[Daniel Brooks [:db48x]]

Attachment: 293114-3.diff

fixes thunderbird too, while I'm at it.

Comment 7

[[e-mail]]

Comment on attachment 183257 [details] [diff] [review]
293114-3.diff

Nice cleanup (although isChecked is now equivalent to checkedLabel == null, so
there's further scope for potential cleanup ;-)

Comment 8

[Daniel Brooks [:db48x]]

oops, I checked this in last week